Repository navigation
Issue 17: Document changing JSONRepresentation to JSONString for PhoneGap 1.3 - #18
Closed
brody2consult wants to merge 3 commits into
Closed
brody2consult wants to merge 3 commits into
brody2consult wants to merge 3 commits into
Conversation
added 3 commits
March 21, 2012 08:31
Owner
|
I think those commits can be squashed into one. The stable version of phonega is 1.5. Does this work for phonegap 1.5 too ? |
Contributor
Author
|
Sorry, I tried to squash the commits but the 3 commits are pushed to master and I cannot take them back. I have closed this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I raised Issue #17 to document that [resultSet JSONString] must be used in place of [resultSet
JSONRepresentation] in Plugins/PGSQLitePlugin.m. I have made this change in my Issue-17 branch and hereby send a pull request. In addition, I added and propose some level-2 headers to make the Installation section a little easier to read.