fix(auth): keep signups from stranding, and show passkey progress - #129
Merged
Merged
Conversation
Abandoning enrolment strands the account: verification already ran, so a retry answers ALREADY_EXISTS, while the otpEmail it enrolled is not a primary factor and signs nobody in. Hides Back, which was the only offered way out, and says plainly what leaving costs. Temporary until Phase C ships recovery.
The chooser only dimmed the entry, which reads as disabled rather than busy. Swaps its icon for the same spinner /login/passkey already shows.
Contributor
🧪 Test Summary
|
Contributor
🧪 Test Summary
|
gaghan430
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Someone who verifies their email but never enrols a passkey ends up locked out for good: signing up again says the address is taken, and the
otpEmailthat verification enrolled can't sign anyone in. The only offered way off that screen was Back. Separately, the passkey entry on/login/methodjust dimmed while the ceremony ran, which reads as disabled rather than busy.Solution
Hide Back on the signup leg and say plainly that leaving means losing the account. Swap the chooser's passkey icon for the same spinner
/login/passkeyalready shows.The warning is a stopgap, not a fix — a closed tab or a device without an authenticator still strands the account. Real recovery is Phase C, and the alert is commented for removal then.
Refs #111