Skip to content

test_has_names fails on missing fft extension #282

Open
Open
test_has_names fails on missing fft extension#282
Labels
medium priorityMedium priority issue

Description

@hameerabbasi
hameerabbasi
opened on Jul 29, 2024

I just got these failures updating to v2023.12 of the standard:

FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-irfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-irfftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-hfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ihfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftfreq] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfftfreq] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftshift] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifftshift] - AttributeError: module 'sparse' has no attribute 'fft'

I'm on commit 827edd804bcace9d64176b8115138d29ae3e8dec.

Activity

  1. rgommers commented on Aug 5, 2024

    @rgommers
    rgommers
    on Aug 5, 2024
    Member

    I think if an extension module is not present, this should either give zero failures or a single failure that must be skipped in the skip file for the library under test.

    Also, in case the decision on the above is "single failure", then it would be good to separate testing extensions out from test_has_names with a single test function per extension module, so that the skip can be done per missing extension.

  2. hameerabbasi commented on Aug 5, 2024

    @hameerabbasi
    hameerabbasi
    on Aug 5, 2024
    ContributorAuthor

    I've looked at the code; the intended behaviour is zero failures. However -- the code is obscured: A fix isn't straightforward.

  3. asmeurer commented on Aug 7, 2024

    @asmeurer
    asmeurer
    on Aug 7, 2024
    Member

    This is just something that I forgot to test properly. The has_names test should automatically skip those tests if the test suite detects that the fft extension is not enabled. For now, you'll just need to skip those tests in your skips file.

  4. asmeurer
    added
    medium priorityMedium priority issue
    on Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    medium priorityMedium priority issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions