Skip to content

Drop Python 3.7 #213

Closed
Closed

Description

@jrbourbeau

I'd like to propose that Dask drops support for Python 3.7. NEP 29 (which there was general interest in for Dask #66) states that support for Python 3.7 can be dropped starting on Dec 26, 2021. Additionally, other projects in the ecosystem (e.g. NumPy, Xarray) have already begun dropping support for Python 3.7. I've brought this up offline with a group of Dask maintainers and they didn't have any objections, but wanted to raise an issue here to solicit feedback from others.

cc @jsignell @quasiben @jakirkham @fjetter @crusaderky @ian-r-rose

Activity

  1. jakirkham commented on Jan 15, 2022

    @jakirkham
    Member

    Generally this sounds like a good idea and should simplify some things in Dask + Distributed.

    That said, there's at least a couple issues I can think of atm.

    First is PyPy hasn't quite made it to 3.8 yet. It sounds like it is close, but may need a few more weeks based on Matti's recent summary here ( conda-forge/conda-forge-pinning-feedstock#2089 (comment) ). Related to that, in conda-forge we are discussing building packages for PyPy 3.8, but this likely needs to wait until things are completed in PyPy as well as for the existing migrations to clear (like Python 3.11). So may take a bit more time before packages are built for PyPy 3.8.

    Second RAPIDS currently still supports Python 3.7. Not exactly sure when we plan to drop that. Maybe Ben can comment.

    Third there are still users/providers on Python 3.7 that haven't yet made the move. Believe Kaggle is one. Not sure who else.

  2. jrbourbeau commented on Jan 20, 2022

    @jrbourbeau
    MemberAuthor

    Thanks for the feedback @jakirkham!

    Second RAPIDS currently still supports Python 3.7. Not exactly sure when we plan to drop that. Maybe Ben can comment.

    @quasiben do you have any insight into when RAPIDS is planning to drop Python 3.7? FWIW it looks like there's some preparation for this which is already underway NVIDIA/cudf#10092

    First is PyPy hasn't quite made it to 3.8 yet. It sounds like it is close, but may need a few more weeks based on Matti's recent summary here ( conda-forge/conda-forge-pinning-feedstock#2089 (comment) )

    That's a fair point and it'd be good for us to be concious of pypy users. That said, with major dependencies like NumPy (latest release is Python 3.8+) and pandas (upcoming 1.4 release is Python 3.8+) dropping support for Python 3.7, it will make it harder for Dask to continue to support Python 3.7. @mattip, thank you for pushing on pypy3.8. Do you have an estimate for when a release might be?

  3. mattip commented on Jan 21, 2022

    @mattip

    It should be done within a month. I want to get a release candidate out next week, covid and flu willing. If dask does drop Python3.7, that only means new versions of dask would not be available, right? It is not as if you would yank the older packages.

  4. quasiben commented on Jan 21, 2022

    @quasiben
    Member

    I think the plan is to drop 3.7 in our upcoming release if we are successful at getting the 3.9 builds working across all RAPIDS libraries.

  5. quasiben commented on Jan 21, 2022

    @quasiben
    Member

    FYI deprecation notice is here: https://docs.rapids.ai/notices/rsn0013/

  6. jakirkham commented on Jan 21, 2022

    @jakirkham
    Member

    If dask does drop Python3.7, that only means new versions of dask would not be available, right? It is not as if you would yank the older packages.

    That's right, Matti

  7. quasiben commented on Jan 31, 2022

    @quasiben
    Member

    @jrbourbeau the rapidsai-nightly channel now has 3.9 packages and will be continuing down the path of dropping 3.7 support

  8. quasiben commented on Feb 3, 2022

    @quasiben
    Member

    I believe RAPIDS has now dropped support for 3.7. All new packages are for published for Python 3.8 and 3.9 in https://anaconda.org/rapidsai/rapids/files and https://anaconda.org/rapidsai-nightly/rapids/files

  9. jrbourbeau commented on Feb 15, 2022

    @jrbourbeau
    MemberAuthor

    Thanks for the update @quasiben -- I'll suggest we go ahead and drop Python 3.7 then

  10. jsignell commented on Feb 15, 2022

    @jsignell
    Member

    Time to merge the PRs?

  11. jrbourbeau commented on Feb 15, 2022

    @jrbourbeau
    MemberAuthor

    Let's get an approval on dask/distributed#5683 first. But then yeah, dask/distributed#5683 and dask/dask#8572 should go in together

  12. jakirkham commented on Feb 16, 2022

    @jakirkham
    Member

    Oh are they done/ready for review?

  13. jakirkham commented on Feb 17, 2022

    @jakirkham
    Member

    This is now complete for Dask + Distributed. Possibly other packages will need similar changes, but that can be followed up on separately. Going to go ahead and close as resolved.

  14. jacobtomlinson commented on Feb 18, 2022

    @jacobtomlinson
    Member

    This has been done in dask-kubernetes too.

  15. jacobtomlinson commented on Mar 1, 2022

    @jacobtomlinson
    Member

    I have noticed that Read the Docs still has Python 3.7 as the default for building documentation and that is causing build errors in places since Dask 2022.2.1 was released. I've raised dask/dask-kubernetes/pull/412 to bump to 3.8 (the highest Read the Docs allows right now) resolve things there. I suspect this will need doing on all projects that use Read the Docs.

  16. jakirkham commented on Mar 1, 2022

    @jakirkham
    Member

    There is a way to override this in a .readthedocs.yaml config file. Maybe this is also overridable in the ReadTheDocs settings?

    FWIW we discussed adding a .readthedocs.yaml config file in issue ( dask/dask#2568 ) and wound up doing this when dropping Python 3.7 ( dask/dask#8572 ).

  17. jacobtomlinson commented on Mar 2, 2022

    @jacobtomlinson
    Member

    There is a way to override this in a .readthedocs.yaml config file. Maybe this is also overridable in the ReadTheDocs settings?

    I couldn't see anything in the UI to set this.

    I've added a .readthedocs.yaml file to dask-kubernetes and that resolved the issue. But this will need to be done for all projects that use Dask/Distributed.

  18. added a commit that references this issue on May 6, 2022
  19. added a commit that references this issue on May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions