Skip to content

fix(drive)!: updating a masternode identity with invalid entry from SML #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 1 commit into from
Apr 24, 2023
Merged

fix(drive)!: updating a masternode identity with invalid entry from SML #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ function synchronizeMasternodeIdentitiesFactory(
.getSMLbyHeight(coreHeight)
.mnList;

const currentValidMNList = currentMNList.filter((entry) => entry.isValid);

const dataContractResult = await dataContractRepository.fetch(
masternodeRewardSharesContractId,
{
Expand All @@ -107,7 +109,7 @@ function synchronizeMasternodeIdentitiesFactory(

if (lastSyncedCoreHeight === 0) {
// Create identities for all masternodes on the first sync
newMasternodes = currentMNList;
newMasternodes = currentValidMNList;
} else {
// simplifiedMasternodeList contains sml only for the last `smlMaxListsLimit` number of blocks
if (coreHeight - lastSyncedCoreHeight >= smlMaxListsLimit) {
Expand All @@ -120,14 +122,14 @@ function synchronizeMasternodeIdentitiesFactory(
}

// Get the difference between last sync and requested core height
newMasternodes = currentMNList.filter((currentMnListEntry) => (
newMasternodes = currentValidMNList.filter((currentMnListEntry) => (
!previousMNList.find((previousMnListEntry) => (
previousMnListEntry.proRegTxHash === currentMnListEntry.proRegTxHash
))
));

// Update operator identities (PubKeyOperator is changed)
for (const mnEntry of currentMNList) {
for (const mnEntry of currentValidMNList) {
const previousMnEntry = previousMNList.find((previousMnListEntry) => (
previousMnListEntry.proRegTxHash === mnEntry.proRegTxHash
&& previousMnListEntry.pubKeyOperator !== mnEntry.pubKeyOperator
Expand Down