Skip to content

feat(dashmate): verbose connect ENOENT /var/run/docker.sock error - #951

Merged
shuplenkov merged 4 commits into
v0.24-devfrom
feat/dashmate_error_handling
Apr 24, 2023
Merged

shuplenkov merged 4 commits into
v0.24-devfrom
feat/dashmate_error_handling

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Apr 20, 2023 •

Copy link
Copy Markdown

Issue being fixed or feature implemented

If docker socket is not accessible, user sees connect ENOENT /var/run/docker.sock message, which is not clear. We need to provide better description with instructions how to solve this.

What was done?

Handle more errors during system requirements check.

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Apr 20, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated
@shumkov shumkov changed the title feat(dashamte): handle connect ENOENT /var/run/docker.sock docker error feat(dashmate): handle connect ENOENT /var/run/docker.sock docker error Apr 24, 2023
@shumkov shumkov changed the title feat(dashmate): handle connect ENOENT /var/run/docker.sock docker error feat(dashmate): verbose connect ENOENT /var/run/docker.sock docker error Apr 24, 2023
@shumkov shumkov changed the title feat(dashmate): verbose connect ENOENT /var/run/docker.sock docker error feat(dashmate): verbose connect ENOENT /var/run/docker.sock error Apr 24, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov
shuplenkov merged commit 3d143e1 into v0.24-dev Apr 24, 2023
@shuplenkov
shuplenkov deleted the feat/dashmate_error_handling branch April 24, 2023 17:13
QuantumExplorer added a commit that referenced this pull request Sep 11, 2026
… references

Advance the GroveDB pin from 985ece65 to develop f75fa362 (GroveDB #949,
#951 and #952). GroveDB #951 replaces the per-call
propagate_backward_references flag with a backward_references_policy on
insert, delete, clear and batch options, defaulting to Maintain on GroveDB
V4 (Platform PV14; PV13 stays on V3). Drive selects Maintain explicitly so
ordinary writes keep backward-reference participants consistent without
each caller predicting them, and every EstimatedLayerInformation declares
may_contain_backward_references: false because Drive stores no
participants, which keeps estimates byte-identical to the previous
flag-less behaviour. GroveDB #949 only changes V4 recursive discovery over
non-Merk descendants and needs no Drive change.

Re-pin twelve PV14 processing-fee baselines in drive-abci: transitions
that remove emptied index subtrees (document delete, transfer and
purchase, group-action confirm) now pay for GroveDB's participant scan of
those subtrees, while batch preparation through retained Merk nodes bills
slightly fewer reads on DPNS create and document replace. PV13 fees are
unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
QuantumExplorer added a commit that referenced this pull request Sep 12, 2026
…declarations

Advance the GroveDB pin to the head of dashpay/grovedb#953 (08003fa2),
which replaces #951's batch-level Maintain/Skip policy with a declaration
on every operation, DisplacedValue::{MayBeParticipant, NotParticipant},
carried by InsertOptions, DeleteOptions, ClearOptions and each
QualifiedGroveDbOp, and drops the per-layer estimator flag.

Drive stores no backward-reference participants, so every op it hands to
GroveDB is declared NotParticipant at the three places Drive applies or
estimates a batch (declaring_no_participants), and its live delete and
clear options say the same. GroveDB checks the claim for free from the
value it reads for the write and refuses a false one, so the declaration
cannot corrupt state. The 165 may_contain_backward_references layer fields
go away with the field.

GroveDB V4 now keeps its single prepared write path for Drive: the
participant scans that raised PV14 delete, transfer and purchase fees
under Maintain are gone, and the retained-node read saving of #951 stays,
so DPNS domain create and document replace are re-pinned 4,000 and 4,900
credits lower. Every other baseline is unchanged; PV13 stays on GroveDB
V3.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants