Skip to content

feat(dpp)!: use blake3 for hashing - #12

Closed
jawid-h wants to merge 23 commits into
masterfrom
dpp/feat/blake3
Closed

jawid-h wants to merge 23 commits into
masterfrom
dpp/feat/blake3

Conversation

@jawid-h

@jawid-h jawid-h commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Trying to use blake3 for hashing

What was done?

  • installed polymorphic @dashevo/blake3
  • async init of the blake
  • updated imports

How Has This Been Tested?

Unit tests

Breaking Changes

  • old hashes are incomatible

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.22.0 milestone Nov 4, 2021
@shumkov shumkov changed the title feat(js-dpp)!: use blake3 for hashing feat(dpp)!: use blake3 for hashing Nov 4, 2021
},
});

await ctx.client.platform.initialize();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be initialized automatically when we call ctx.client.platform.contracts.get

@jawid-h

jawid-h commented Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

The reason checks are not passing is that in Drive, an initialization of DPP (dpp.initialize) is hanging during loading of blake3 WASM.

@thephez

thephez commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

@jawid-h Is this postponed until a later release? Or will it still be part of v0.22?

@shumkov

shumkov commented Feb 18, 2022

Copy link
Copy Markdown
Collaborator

@thephez This is posponed for v0.23

@shumkov
shumkov changed the base branch from v0.22-dev to v0.23-dev March 21, 2022 15:29
@shumkov
shumkov changed the base branch from v0.23-dev to v0.24-dev September 30, 2022 11:38
@shumkov shumkov modified the milestones: v0.22.0, v0.22.x, v0.24.0 Sep 30, 2022
shumkov pushed a commit that referenced this pull request Nov 23, 2022
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@shumkov shumkov modified the milestones: v0.24.0, v0.25.0 May 10, 2023
@shumkov
shumkov changed the base branch from v0.24-dev to master May 10, 2023 04:13
@shumkov shumkov closed this May 10, 2023
@shumkov
shumkov deleted the dpp/feat/blake3 branch May 10, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants