Repository navigation
feat(dpp): better json schema error messages for data contracts - #1175
Closed
pauldelucia wants to merge 10 commits into
Closed
pauldelucia wants to merge 10 commits into
pauldelucia wants to merge 10 commits into
Conversation
pauldelucia
requested review from
QuantumExplorer,
antouhou and
shumkov
as code owners
June 20, 2023 07:48
3 of 23 tasks
7 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Better error messages when data contract validation hits a JsonSchemaError
What was done?
Add "error_message" field to JsonSchemaErrorData that stores messages from jsonschema library. Link the previously unused "error_summary" field from JsonSchemaError to JsonSchemaErrorData "error_message". Change error message format for JsonSchemaError.
How Has This Been Tested?
Works when used with dashpay/data-contract-creator
Breaking Changes
Checklist:
For repository code-owners and collaborators only