Skip to content

feat: fetch data contract history endpoint - #1149

Merged
shumkov merged 53 commits into
v0.25-devfrom
feat-dapi-fetch-history
Jul 7, 2023
Merged

feat: fetch data contract history endpoint#1149
shumkov merged 53 commits into
v0.25-devfrom
feat-dapi-fetch-history

Conversation

@antouhou

@antouhou antouhou commented Jun 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Fetch contract history in SDK

What was done?

  • Added fetch method to dapi
  • Added fetch method and related data structures to dapi-client, unit tests
  • Added fetch method to SDK, unit tests
  • Added check that the history is correct and fetchable in test suite

How Has This Been Tested?

Run tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou changed the title feat: dapi fetch history feat: Fetch history endpoint Jun 6, 2023
@antouhou antouhou changed the title feat: Fetch history endpoint feat(dapi, sdk, test-suite): Fetch history endpoint Jun 6, 2023
@antouhou
antouhou marked this pull request as ready for review June 6, 2023 08:10
@antouhou
antouhou requested a review from shumkov as a code owner June 6, 2023 08:10
@antouhou antouhou changed the title feat(dapi, sdk, test-suite): Fetch history endpoint feat(sdk): Fetch history endpoint Jun 6, 2023
@antouhou antouhou changed the title feat(sdk): Fetch history endpoint feat(sdk, dapi, test-suite): fetch history endpoint Jun 6, 2023
@pshenmic

pshenmic commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

This is going to be very useful!

@shumkov shumkov changed the title feat(sdk, dapi, test-suite): fetch history endpoint feat: fetch history endpoint Jun 13, 2023
@shumkov shumkov changed the title feat: fetch history endpoint feat: fetch data contract history endpoint Jun 13, 2023
QuantumExplorer
QuantumExplorer reviewed Jun 20, 2023
View reviewed changes
Comment thread packages/dapi-grpc/protos/platform/v0/platform.proto Outdated
shumkov
shumkov requested changes Jun 27, 2023
View reviewed changes
Comment thread packages/js-dash-sdk/src/SDK/Client/Platform/methods/contracts/history.ts
shumkov
shumkov approved these changes Jul 7, 2023
View reviewed changes

@shumkov shumkov left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far it's only initial task to provide contract versions functionality for SDK it's fine 👍

@shumkov
shumkov merged commit ec839d2 into v0.25-dev Jul 7, 2023
@shumkov
shumkov deleted the feat-dapi-fetch-history branch July 7, 2023 09:29
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
@lklimek lklimek mentioned this pull request Oct 9, 2026
Open
9 of 22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer left review comments
@shumkov shumkov shumkov approved these changes
+1 more reviewer
@markin-io markin-io markin-io approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.25.0

Development

Successfully merging this pull request may close these issues.

6 participants

@antouhou @pshenmic @shumkov @markin-io @QuantumExplorer @thephez