Skip to content

chore!: disable protocol version signaling - #1029

Merged
shumkov merged 2 commits into
v0.24-devfrom
chore/disable_protocol_version_signaling
May 4, 2023
Merged

shumkov merged 2 commits into
v0.24-devfrom
chore/disable_protocol_version_signaling

Conversation

@shumkov

@shumkov shumkov commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

The protocol version signaling logic has source on non-determinsm

What was done?

  • Disabled for v0.24 so we can investigate and fix it in v0.25 if it's still exist

How Has This Been Tested?

On testnet

Breaking Changes

Previous state won't be valid

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
shumkov requested a review from antouhou as a code owner May 4, 2023 14:54
@shumkov
shumkov merged commit 180c428 into v0.24-dev May 4, 2023
@shumkov
shumkov deleted the chore/disable_protocol_version_signaling branch May 4, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants