You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bumps the version to 0.26.2 for the next npm release. Merge after #328, so the release contains its check that masternode list diff writers get 32-byte hashes and 20-byte evonode node IDs.
This is a patch release, so ~0.26.1 and ^0.26.1 dependents (such as Platform) pick it up without a dependency change. The new checks only reject hand-built objects that already serialized to broken messages. Parsed data is unaffected.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 8a3502c3-0289-4175-b3c1-8f0765c5d68f
Commits
Reviewing files that changed from the base of the PR and between 62d551b and 703f2b7.
Files ignored due to path filters: 1
package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1
package.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The package version in package.json changes from 0.26.1 to 0.26.2.
Changes: Release version
Layer / File(s)
Summary
Update package version package.json
The package version changes from 0.26.1 to 0.26.2.
dashpay/dashcore-lib#328: This PR adds writer-side checks included in the release associated with this version bump.
Suggested reviewers:shumkov
Merge Risk: Minimal · up to 703f2
The 0.26.2 version bump is consistent; the planned serialization checks are not included at this head.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the version change shown in package.json, from 0.26.1 to 0.26.2. The objective text mentions 0.27.0, but the title matches the provided changeset and commit s…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title clearly and concisely describes the version change shown in package.json, from 0.26.1 to 0.26.2. The objective text mentions 0.27.0, but the title matches the provided changeset and commit summary.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
package.json
Parsing error: Unexpected token :
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Final review — Phase 1 only (trivial change)
At a37be69, the diff only updates package.json and both package-lock.json version fields from 0.26.1 to 0.27.0; no in-scope issues were found. PR #328's validation changes support the stated release rationale, and the documented merge ordering remains necessary to include them. The current CI test check passes and npm publishing is skipped as expected; no local builds or tests were run.
Triage: trivial by gpt-6.1-sol (effort low) — The diff only updates release version metadata in package.json and package-lock.json, without changing code, dependencies, or runtime behavior.
The reason will be displayed to describe this comment to others. Learn more.
Re-review — Final review — Phase 1 only (trivial change)
At head 703f2b7, the diff only bumps package.json and both root version fields in package-lock.json to 0.26.2, consistently with prior release bumps. No actionable findings were supplied or identified; merging after #328 remains the release-order requirement stated in the PR description. The supplied exact-head CI snapshot reports tests passing and npm publication skipped as expected for a PR; no local builds or tests were run.
Triage: trivial by gpt-6.1-sol (effort low) — The diff only updates package metadata and the lockfile version for a release, with no behavior or critical-surface changes.
Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 0.26.2 for the next npm release. Merge after #328, so the release contains its check that masternode list diff writers get 32-byte hashes and 20-byte evonode node IDs.
This is a patch release, so
~0.26.1and^0.26.1dependents (such as Platform) pick it up without a dependency change. The new checks only reject hand-built objects that already serialized to broken messages. Parsed data is unaffected.🤖 Generated with Claude Code
Summary by CodeRabbit