Repository navigation
/concurrency: improve RunnerManager performance and readability - #143
Merged
Merged
Conversation
Refactor RunnerManager.Run to enhance robustness, performance, and readability. Added an early return for an empty list of runners to handle edge cases more efficiently. Buffered the error channel (`errCh`) with a capacity equal to the number of runners. This prevents goroutines from blocking when multiple runners complete simultaneously, leading to slight performance improvements in high-concurrency scenarios. Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors concurrency.RunnerManager.Run to improve execution behavior under concurrency and make the control flow easier to follow.
Changes:
- Add early return when the runner list is empty.
- Buffer
errChtolen(r.runners)to avoid runner goroutines blocking on sends. - Simplify runner completion/error handling and error collection loop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acroca
reviewed
Mar 2, 2026
Signed-off-by: joshvanl <me@joshvanl.dev>
acroca
approved these changes
Mar 3, 2026
cicoyle
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor RunnerManager.Run to enhance robustness, performance, and readability.
Added an early return for an empty list of runners to handle edge cases more efficiently.
Buffered the error channel (
errCh) with a capacity equal to the number of runners. This prevents goroutines from blocking when multiple runners complete simultaneously, leading to slight performance improvements in high-concurrency scenarios.