Repository navigation
Conversation
The HTTP subscriber compared the whole datacontenttype string, so a JSON payload in data_base64 stayed raw bytes when the type included a parameter such as charset. Parse the media type, as the gRPC subscriber does, and decode only application/json. Fixes dapr#855 Signed-off-by: eisen0419 <usetoken0419@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
service/http,topicEventJSON.getData()previously comparedin.DataContentType == "application/json"literally when decoding adata_base64CloudEvent payload. Whendatacontenttypeincluded media type parameters such asapplication/json; charset=utf-8,TopicEvent.Datastayed raw[]byteinstead of matching the decoded JSON value returned for plainapplication/jsonand by the gRPC subscriber.Parse
in.DataContentTypewithmime.ParseMediaTypein thedata_base64branch and JSON-unmarshalrawDatawhen the parsed media type isapplication/json, preservingRawData, the originalDataContentTypestring, and raw[]bytefallback for non-JSON, malformed media types, or invalid JSON.Issue reference
Please reference the issue this PR will close: #855
Fixes #855
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: