Repository navigation
Conversation
DAPR_GRPC_ENDPOINT takes ?authority=, sent as :authority and SNI so a proxy can route the connection while the target only reaches the proxy. With DAPR_CLIENT_TLS_CERT_FILE/KEY_FILE and DAPR_TLS_TRUST_ANCHORS_FILE set, the client presents that certificate and holds the server to a SPIFFE ID (DAPR_SERVER_SPIFFE_ID, default its own) instead of a host name. A dial timeout now reports the last connection error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lrascao
marked this pull request as draft
November 6, 2026 17:43
Contributor
|
@lrascao can we use this var names DAPR_GRPC_TLS_CERT_PATH, DAPR_GRPC_TLS_KEY_PATH, DAPR_GRPC_TLS_CA_PATH and DAPR_GRPC_TLS_SERVER_SPIFFE_ID ?? The first 3 already exists on Java sdk for the same purpose. |
…eaning DAPR_GRPC_TLS_CERT_PATH, DAPR_GRPC_TLS_KEY_PATH and DAPR_GRPC_TLS_CA_PATH now behave as in the Java SDK: any of them turns TLS on, the CA replaces the system roots, and the server is checked by host name. The SPIFFE ID check runs only when DAPR_GRPC_TLS_SERVER_SPIFFE_ID is set, and needs the CA. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Renamed, and they now behave as they do in Java: any of them turns TLS on, the CA replaces the system roots, and the server is checked by host name. The SPIFFE check only runs when DAPR_GRPC_TLS_SERVER_SPIFFE_ID is set. One difference I kept: a cert without its key fails here instead of being ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DAPR_GRPC_ENDPOINT takes ?authority=, sent as :authority and SNI, so a proxy can route the connection while the endpoint only has to reach the proxy.
The client reads the gRPC TLS settings the Java SDK reads, with the same meaning: DAPR_GRPC_TLS_CERT_PATH and DAPR_GRPC_TLS_KEY_PATH are the client certificate, DAPR_GRPC_TLS_CA_PATH replaces the system roots, and setting any of them turns TLS on. DAPR_GRPC_TLS_SERVER_SPIFFE_ID swaps the host name check for a SPIFFE ID check, for a server whose certificate names no host, such as a daprd reached over mTLS. Unlike Java, a certificate without its key is an error rather than ignored.
A dial timeout now reports the last connection error.