Repository navigation
Fixing workflow tracing + adding observability integration testing - #1870
Merged
Merged
Conversation
…ng to `Dapr.Testcontainers` to more properly validate it. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…emetry from the Zipkin endpoint on the Dapr runtime to add to the integration testing suite Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ure across various scenarios: - Activity runtime-to-SDK span continuity - Child workflow activity tracing - Retry attempts - Fan-out/fan-in parallel activities - Timer plus external event before activity execution - Multi-app remote activity - Activity failure span status - Continue-as-new - Multi-app child workflow - Downstream custom ActivitySource parented under the workflow activity span - Suspend/resume (validate activity after resume) - Re-run workflow (validating spans for rerun instance) - History propagation with OwnHistory - History propagation with Lineage - Parallel child workflows, validating each child activity trace - Terminate (validating for work completed before termination and terminated history) Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… tracing: - Caught activity failure/compensation (validate activity span is marked error - Workflow failure after activity failure (validate trace when activity failure is not caught and workflow ends as failed) - Child workflow + activity in both parent and child (validates activity in the child) Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ith the expected dispaly name, the span has the same trace id as the runtime span, the span's ParentSpanId equals the runtime span Id and that the runtime exports a Zipkin activity span with the expected runtime name Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ble accurate scenarios and requirements Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1870 +/- ##
==========================================
- Coverage 63.19% 62.17% -1.02%
==========================================
Files 330 334 +4
Lines 9534 9700 +166
Branches 1110 1127 +17
==========================================
+ Hits 6025 6031 +6
- Misses 3197 3356 +159
- Partials 312 313 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 12, 2026
WhitWaldo
added a commit
that referenced
this pull request
Jul 13, 2026
…1873) * Fixing workflow tracing + adding observability integration testing (#1870) * Implementing better trace support in Dapr.Workflow + adding e2e testing to `Dapr.Testcontainers` to more properly validate it. * Added functionality to `Dapr.Testcontainers` to support capturing telemetry from the Zipkin endpoint on the Dapr runtime to add to the integration testing suite * Added a series of integration tests to validate proper telemetry capture across various scenarios: - Activity runtime-to-SDK span continuity - Child workflow activity tracing - Retry attempts - Fan-out/fan-in parallel activities - Timer plus external event before activity execution - Multi-app remote activity - Activity failure span status - Continue-as-new - Multi-app child workflow - Downstream custom ActivitySource parented under the workflow activity span - Suspend/resume (validate activity after resume) - Re-run workflow (validating spans for rerun instance) - History propagation with OwnHistory - History propagation with Lineage - Parallel child workflows, validating each child activity trace - Terminate (validating for work completed before termination and terminated history) - Caught activity failure/compensation (validate activity span is marked error - Workflow failure after activity failure (validate trace when activity failure is not caught and workflow ends as failed) - Child workflow + activity in both parent and child (validates activity in the child) * Corrected to validate that the `Dapr.Workflow` activity span exists with the expected display name, the span has the same trace id as the runtime span, the span's ParentSpanId equals the runtime span Id and that the runtime exports a Zipkin activity span with the expected runtime name Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Improved existing orchestration tests to make them more closely resemble accurate scenarios and requirements --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added mechanism to pass environment variables into daprd as part of integration testing with `Dapr.Testcontainers` (#1871) Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Jul 26, 2026
Closed
This was referenced Aug 20, 2026
This was referenced Sep 7, 2026
Open
This was referenced Sep 14, 2026
This was referenced Sep 23, 2026
This was referenced Oct 5, 2026
This was referenced Oct 19, 2026
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the generous assistant in pinpointing the issue of otel tracing in
Dapr.Workflows, this PR applies a patch to make such tracing automatic as part of the outbound gRPC calls.But because this has been a recurring ticket, it also expands the
Dapr.Testcontainersimplementation to add a Zipkin endpoint to pull the telemetry from the Dapr runtime and validate that the tracing encompasses the appropriate spans for more than a dozen of the common Workflow scenarios to ensure that not only does this patch work, but to also prevent future regression.This only targets Workflows because it's the only part of the SDK that shares work with the runtime. All other packages either defer entirely to the runtime or simply don't need their own tracing (preferring that the developer bring their own and auto-register transport, for example).
Once support for head-less workflows is implemented (as is planned for the 1.19 release), this will be expanded to accommodate that scenario as well.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1867
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: