Repository navigation
Workflow: Adds docs for stateful workflow client - #5310
Merged
Merged
Conversation
Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both Go examples pass incompatible option types to NewWorkflowClient and will not compile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds documentation for Dapr v1.19’s stateful workflow-history caching and related behavior.
Changes:
- Documents caching, eviction, worker affinity, configuration, and compatibility.
- Adds cross-references from workflow architecture, concepts, and payload-size docs.
- Provides SDK-specific configuration examples.
File summaries
| File | Description |
|---|---|
workflow-stateful-client.md |
Adds the feature guide and SDK examples. |
workflow-payload-size.md |
Clarifies payload-limit behavior with deltas. |
workflow-features-concepts.md |
Adds a feature summary and link. |
workflow-architecture.md |
Documents incremental history delivery. |
Review details
Suppressed comments (1)
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-stateful-client.md:252
- These cache options are
TaskHubGrpcClientOptionvalues, butclient.NewWorkflowClientonly accepts...grpc.DialOption, so this tuning example cannot compile. Please expose/pass the durable-task worker options through a supported Go SDK API, or omit this tab until such an API exists.
wclient, err := client.NewWorkflowClient(
dtclient.WithWorkflowHistoryCacheTTL(10*time.Minute),
dtclient.WithWorkflowHistoryCacheMaxInstances(10_000),
dtclient.WithWorkflowHistoryCacheMaxBytes(256*1024*1024),
)
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.