Skip to content

Workflow: Adds docs for stateful workflow client - #5310

Merged
marcduiker merged 2 commits into
dapr:v1.19from
JoshVanL:wf-stateful-client
Oct 15, 2026
Merged

marcduiker merged 2 commits into
dapr:v1.19from
JoshVanL:wf-stateful-client

Conversation

@JoshVanL

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: joshvanl <me@joshvanl.dev>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both Go examples pass incompatible option types to NewWorkflowClient and will not compile.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds documentation for Dapr v1.19’s stateful workflow-history caching and related behavior.

Changes:

  • Documents caching, eviction, worker affinity, configuration, and compatibility.
  • Adds cross-references from workflow architecture, concepts, and payload-size docs.
  • Provides SDK-specific configuration examples.
File summaries
File Description
workflow-stateful-client.md Adds the feature guide and SDK examples.
workflow-payload-size.md Clarifies payload-limit behavior with deltas.
workflow-features-concepts.md Adds a feature summary and link.
workflow-architecture.md Documents incremental history delivery.
Review details

Suppressed comments (1)

daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-stateful-client.md:252

  • These cache options are TaskHubGrpcClientOption values, but client.NewWorkflowClient only accepts ...grpc.DialOption, so this tuning example cannot compile. Please expose/pass the durable-task worker options through a supported Go SDK API, or omit this tab until such an API exists.
wclient, err := client.NewWorkflowClient(
	dtclient.WithWorkflowHistoryCacheTTL(10*time.Minute),
	dtclient.WithWorkflowHistoryCacheMaxInstances(10_000),
	dtclient.WithWorkflowHistoryCacheMaxBytes(256*1024*1024),
)
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@CasperGN CasperGN assigned CasperGN and unassigned CasperGN Oct 12, 2026

@marcduiker marcduiker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcduiker
marcduiker merged commit 15186da into dapr:v1.19 Oct 15, 2026
5 checks passed
@nelson-parente nelson-parente added this to the v1.19 milestone Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants