Repository navigation
Document RabbitMQ pub/sub externally managed topology and consistent hash exchange - #5297
Merged
alicejgibbons merged 17 commits intoOct 15, 2026
Merged
Conversation
…hash exchange Adds reference for the new exchangeDeclareMode and queueDeclareMode metadata fields, and for the x-consistent-hash exchange kind. Also corrects the exchangeKind allowed values, which listed only fanout and topic although direct and headers have long been accepted. Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
5 tasks done
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
MyMirelHub
marked this pull request as ready for review
August 26, 2026 05:20
The component validates exchangeKind against the same allowlist in both declare modes, matching the allowedValues in metadata.yaml. Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Dead lettering follows queueDeclareMode, not exchangeDeclareMode; a consistent hash subscription takes exactly one bucket weight; passive mode accepts any broker-supported exchange kind. Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
…logy-modes Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com> # Conflicts: # daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
alicejgibbons
requested changes
Oct 12, 2026
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Alice Gibbons <alicejgibbons@gmail.com> Signed-off-by: Mirel <15373565+MyMirelHub@users.noreply.github.com>
- Add Python and JavaScript alongside Go for the consistent hash publish example, matching the rest of the page. - Name exchangeDeclareMode and queueDeclareMode where the text said "the two". - Move the mode bullets above the example, fold the trailing sentence into the note, and take the suggested wording on the collision sentence. Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
CasperGN
approved these changes
Oct 12, 2026
CasperGN
left a comment
Contributor
There was a problem hiding this comment.
Round 2 of 3: follow-up on the changes since 0b17ecd.
Every earlier blocker is resolved and the new changes add none.
Nits, not blocking:
- F1: Dead-letter paragraph says no external owner can pre-create the DLX/DLQ, then says they are left to the queue owner; reword for clarity (
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md) - F2: Awkward wording for the error when a passive exchange or queue is missing (
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md)
Drafted with AI assistance and reviewed by me.
The dead-letter paragraph read as a contradiction: runtime-derived names mean no external owner can pre-create those objects, yet passive mode leaves them to the queue owner. Split it by mode instead. Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Contributor
Author
|
Both addressed in the latest commit, thanks @CasperGN. F1: the paragraph was conflating two modes. Runtime-derived names are the reason dead lettering follows F2: reworded to say it fails with an error naming the missing object and the mode that stopped it being created. |
alicejgibbons
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the two RabbitMQ pub/sub features added in dapr/components-contrib#4552, and fixes an existing inaccuracy in the same page.
exchangeDeclareMode/queueDeclareMode— new section Use an externally managed topology, for brokers whose exchanges and queues are owned by the RabbitMQ Topology Operator, Terraform, or similar. Covers why the collision happens (PRECONDITION_FAILED), what each mode asserts, that dead-letter objects follow the same rule, and that queue arguments become the external owner's responsibility underqueueDeclareMode: passive.x-consistent-hash— new section Use a consistent hash exchange for partitioned ordering. The part worth being explicit about is thatroutingKeymeans the partition key when publishing and the queue's integer bucket weight when subscribing.exchangeKindallowed values — the table listed onlyfanoutandtopic.directandheadershave long been accepted by the component; this corrects the row and addsx-consistent-hash.Issue reference
Documents dapr/components-contrib#4553 and dapr/components-contrib#4554.
Checklist