Repository navigation
refactor(but): cleanup code quality - #3
Merged
Merged
Conversation
Rename the FileMeta interface to FileMetadata throughout the codebase for improved clarity. Add JSDoc comments to document GitButler-specific fields and interfaces including virtual branches and lane metadata. Improve the runBut function in gitbutler.ts by adding a configurable timeout parameter with 30-second default and proper error handling with process termination on timeout. Add helper functions buildFileMeta and addLaneDetail to construct per-lane committed/uncommitted breakdown metadata. Simplify hideLaneLabel logic to check for gitbutler:workspace instead of counting colons.
dansusman
commented
Apr 15, 2026
dansusman
left a comment
Owner
Author
There was a problem hiding this comment.
Hopefully this makes the feature slightly easier to maintain/iterate on long term
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the FileMeta interface to FileMetadata throughout the
codebase for improved clarity. Add JSDoc comments to document
GitButler-specific fields and interfaces including virtual
branches and lane metadata.
Improve the runBut function in gitbutler.ts by adding a
configurable timeout parameter with 30-second default and
proper error handling with process termination on timeout.
Add helper functions buildFileMeta and addLaneDetail to
construct per-lane committed/uncommitted breakdown metadata.
Simplify hideLaneLabel logic to check for gitbutler:workspace
instead of counting colons.