Skip to content

refactor(but): cleanup code quality - #3

Merged
dansusman merged 1 commit into
mainfrom
susman/cleanup
Apr 15, 2026
Merged

dansusman merged 1 commit into
mainfrom
susman/cleanup

Conversation

@dansusman

Copy link
Copy Markdown
Owner

Rename the FileMeta interface to FileMetadata throughout the
codebase for improved clarity. Add JSDoc comments to document
GitButler-specific fields and interfaces including virtual
branches and lane metadata.

Improve the runBut function in gitbutler.ts by adding a
configurable timeout parameter with 30-second default and
proper error handling with process termination on timeout.

Add helper functions buildFileMeta and addLaneDetail to
construct per-lane committed/uncommitted breakdown metadata.

Simplify hideLaneLabel logic to check for gitbutler:workspace
instead of counting colons.

Rename the FileMeta interface to FileMetadata throughout the
codebase for improved clarity. Add JSDoc comments to document
GitButler-specific fields and interfaces including virtual
branches and lane metadata.

Improve the runBut function in gitbutler.ts by adding a
configurable timeout parameter with 30-second default and
proper error handling with process termination on timeout.

Add helper functions buildFileMeta and addLaneDetail to
construct per-lane committed/uncommitted breakdown metadata.

Simplify hideLaneLabel logic to check for gitbutler:workspace
instead of counting colons.

@dansusman dansusman left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this makes the feature slightly easier to maintain/iterate on long term

@dansusman
dansusman merged commit c9592a4 into main Apr 15, 2026
@dansusman
dansusman deleted the susman/cleanup branch April 15, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant