Repository navigation
Conversation
daniatic
added
bug
Owner
Author
|
@coderabbitai full review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review the executable resolver fix before it merges upstream in Fallout PR #704.
This is a review copy on the contributor fork. Existing exact paths keep precedence, only extensionless Windows paths can use the .exe fallback, and missing paths still fail.
Verification
All 69 Fallout.Tooling.Specs tests passed on Windows. The regression test fails against the original resolver. The compatibility fixtures include competing exact/suffixed files and reject rewriting an explicitly supplied extension. The full contributor build.ps1 Test target passed with both fixes: 830 passed, seven existing CI-environment tests skipped.
Reviews
Two independent local agents reviewed the final head and found no defects. CodeRabbit was requested manually but has not produced a review result so far. No paid reviewer was requested for this six-line change after two independent reviews.