Skip to content

test(indexing): broaden planner property coverage - #334

Closed
d-v-b wants to merge 7 commits into
codex/zarr-indexing-factual-auditfrom
codex/indexing-planner-properties
Closed

d-v-b wants to merge 7 commits into
codex/zarr-indexing-factual-auditfrom
codex/indexing-planner-properties

Conversation

@d-v-b

@d-v-b d-v-b commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

🤖 AI text below 🤖

The planner's generated dependency-graph tests previously used zero-origin requests and a single nonnegative fixed grid. Expand the pointwise oracle to signed request origins, translated custom grids with signed chunk IDs, arbitrary broadcast ArrayMap dependencies, independent affine axes, ConstantMaps, offsets and strides, duplicate storage points, and empty requests. The oracle enumerates small transforms independently of planner grouping and verifies exact request/storage pairs, each request position exactly once, and the touched chunk set.

Add separate generated checks for shared affine dependencies and mixed affine/array dependencies, which the planner currently rejects explicitly. No production behavior changes.

Validation: 1,523 package tests passed; all applicable prek checks passed. Temporarily removing the negative chunk-ID guard in _chunk_keys made the expanded property fail on an out-of-bounds chunk-local coordinate (1 failed, 121 deselected); production code was restored and the 122 planner tests passed again. No new production defects were found.

Stacked on #333, targeting codex/zarr-indexing-factual-audit.

* fix: complete imagecodecs codec package hints

Assisted-by: Codex:GPT-6

* docs: associate codec changelog with PR 338

Assisted-by: Codex:GPT-6

* docs: associate codec changelog with upstream PR 4351

Assisted-by: Codex:GPT-6
…r-developers#4345)

* docs(indexing): ground design and integration claims in current behavior

Assisted-by: Codex:GPT-6

* docs(indexing): correct reader lazy-array and cache contracts

Assisted-by: Codex:GPT-6

* fix(indexing): validate wire boundaries and clarify format contracts

Assisted-by: Codex:GPT-6

* fix(indexing): validate selector bounds and shared dependencies

Correct mathematical API documentation to match supported coordinate, grid, and chunk projection contracts.

Assisted-by: Codex:GPT-6

* docs(indexing): reconcile reader contracts and record audit fixes

Assisted-by: Codex:GPT-6

* docs(indexing): reconcile audit with current partition implementation

Retain the existing unsigned selector fix and update the unsupported mixed-dependency error assertion for general intersection routing.

Assisted-by: Codex:GPT-6

* docs(indexing): clarify planning coverage and benchmark measurement boundaries

Assisted-by: Codex:GPT-6

* fix(indexing): group signed chunk coordinates without collisions

Use lexicographic tuple grouping when chunk indices contain negative values. Cover shared one-axis and two-axis array dependencies, repeated points, and extreme signed coordinates.

Assisted-by: Codex:GPT-6

* docs(indexing): state remaining planner limits precisely

Assisted-by: Codex:GPT-6

* docs(indexing): number audit changelog entries for PR 4345

Assisted-by: Codex:GPT-6

* docs(indexing): describe current contracts in docstrings

Remove implementation history and unsupported historical claims from source and test docstrings. Distinguish immutable coordinate mappings from mutable source values.

Assisted-by: Codex:GPT-6
@d-v-b

d-v-b commented Sep 30, 2026

Copy link
Copy Markdown
Owner Author

🤖 AI text below 🤖

The agent closed this draft as superseded: its head is byte-identical under packages/zarr-indexing to the squash commit that merged upstream as zarr-developers#4346.

@d-v-b d-v-b closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant