Skip to content

[Bug]: AbstractLoader::JOIN (or LEFT_JOIN) for public use#202

Description

@gam6itko

No duplicates 馃ゲ.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

Describe the bug

I often use constructions like

$select = $this->getOrm()->getRepository(Country::class)
    ->select()
    ->with('translation', [
        'as' => 'trans',
        'method' => JoinableLoader::LEFT_JOIN, //internal
        'where' => [
            'locale_id' => 1,
        ],
]);

but the psalm generates errors

 InternalClass - App\MyClass.php:164:34 - Cycle\ORM\Select\JoinableLoader is internal to Cycle but called from App\MyClass (see https://psalm.dev/174)

Pleas make not internal constant which I use without psalm errors.

Is this a regression?

No

To Reproduce

see above

Expected behaviour

see above

Media prove

No response

Database

MySQL

Your environment

No response

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions