move to cvxsimulator - #588
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames module references from "cvx.simulator" to "cvxsimulator" throughout the codebase to consolidate the simulator’s namespace.
- Updated import statements in tests, examples, and documentation.
- Removed the old "cvx/simulator" module and updated configuration files and workflows accordingly.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/test_applications/test_talk/test_experiment3.py | Changed Portfolio import from cvx.simulator.portfolio to cvxsimulator.portfolio. |
| src/tests/test_applications/test_talk/test_experiment2.py | Changed Portfolio import from cvx.simulator.portfolio to cvxsimulator. |
| src/tests/test_applications/test_talk/test_experiment1.py | Changed Portfolio import from cvx.simulator.portfolio to cvxsimulator. |
| src/tests/test_applications/test_talk/conftest.py | Updated interpolation import to use cvxsimulator. |
| src/tests/test_applications/test_reference/test_markowitz.py | Changed Builder import to use cvxsimulator.builder. |
| src/cvxsimulator/utils/init.py | Added new interpolation functions to all. |
| src/cvxsimulator/init.py | New module initialization for cvxsimulator. |
| src/cvx/simulator/init.py | Removed the deprecated module. |
| pyproject.toml | Updated package path exclusions and package configuration. |
| .github/workflows/*.yml | Updated import paths in workflow configuration. |
| book/marimo/*.py & README.md | Updated code examples to reference the new module name. |
| from tinycta.signal import osc, returns_adjust | ||
|
|
||
| from cvx.simulator.portfolio import Portfolio | ||
| from cvxsimulator.portfolio import Portfolio |
There was a problem hiding this comment.
The import for Portfolio differs across tests; test_experiment3.py uses 'cvxsimulator.portfolio' while test_experiment1.py and test_experiment2.py use 'cvxsimulator'. Consider standardizing the import statement to maintain consistency across the codebase.
Suggested change
| from cvxsimulator.portfolio import Portfolio | |
| from cvxsimulator import Portfolio |
tschm
force-pushed
the
587-change-to-cvxsimulator
branch
from
June 9, 2025 18:59
cfc940e to
43069ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.