Repository navigation
Update test files - #665
Open
droberts-ctrlo wants to merge 9 commits into
Open
droberts-ctrlo wants to merge 9 commits into
droberts-ctrlo wants to merge 9 commits into
Conversation
droberts-ctrlo
commented
Sep 25, 2026
droberts-ctrlo
commented
Contributor
- Update test workflow to use debian:trixie-slim container
- Update cypress test to use debian:trixie-slim container
- Remove obsolete WebDriver test files
droberts-ctrlo
marked this pull request as ready for review
September 25, 2026 12:14
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - appears fine to me.
- Update test workflow to use debian:trixie-slim container - Update cypress test to use debian:trixie-slim container - Remove obsolete WebDriver test files
droberts-ctrlo
force-pushed
the
workflow-fixes
branch
from
October 5, 2026 15:21
d3358b7 to
5370af5
Compare
abeverley
reviewed
Oct 6, 2026
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
| nvm install ${{ matrix.browser.node_version }} | ||
| nvm use ${{ matrix.browser.node_version }} | ||
| npm i -g yarn && npm i -g --allow-scripts=yarn |
Contributor
There was a problem hiding this comment.
Can we use the nodejs version that is bundled with the OS? This would provide better representative testing and also flag if/when the bundled node version is not high enough
Contributor
Author
There was a problem hiding this comment.
NVM is used as this allows for the latest version of Node - some of the more up-to-date libraries complain if you use the system Node version. As the build takes place locally, and is not done on the server, using this is easier. We don't use node server-side, just for building and testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.