Remove openshift/python-daemon/pexpect packages - #920
Open
cigamit wants to merge 5 commits into
Open
Conversation
cigamit
commented
Sep 12, 2026
cigamit
commented
Collaborator
- Openshift package is not imported directly, so drop it and just bring in the kubernetes package, which we do need.
- Ansible-Runner finally dropped python-daemon yesterday, which removes it and lockfile
- We also don't use pexpect, so remove our pin. Its still brought in by Ansible-Runner though.
Still included in by ansible-runner
cigamit
added
dependencies
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical minikube preflight and moderate pexpect compatibility issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request cleans up unused Python dependencies while adding Kubernetes explicitly.
Changes:
- Adds
kubernetesas a direct dependency. - Removes
openshift,python-daemon,lockfile, and the directpexpectpin. - Regenerates the locked requirements.
File summaries
| File | Summary | Findings |
|---|---|---|
requirements/requirements.in |
Updates direct dependency declarations. | Critical (3 votes): Minikube preflight still requires openshift. Moderate (2 votes): Retain pexpect==4.7.0 until Ansible Runner updates its incompatible usage. |
requirements/requirements.txt |
Regenerates the resolved dependency lockfile. | No findings. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.