Skip to content

fix: hand HTTPBasicAuth a real PreparedRequest #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaipr wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: hand HTTPBasicAuth a real PreparedRequest #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ascenderkit/api/pages/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import collections
import logging

from requests import PreparedRequest
from requests.auth import HTTPBasicAuth
from requests.structures import CaseInsensitiveDict

from ascenderkit.api.pages import Page, exception_from_status_code
from ascenderkit.config import config
Expand Down Expand Up @@ -131,7 +132,14 @@ def get_oauth2_token(self, username='', password='', client_id=None, description
default_cred = config.credentials.default
username = username or default_cred.username
password = password or default_cred.password
req = collections.namedtuple('req', 'headers')({})
# HTTPBasicAuth.__call__ sets Authorization on the request it is given
# and returns it, which is the only reason a request object is built
# here. It used to be a namedtuple with a headers attribute, which
# works because __call__ touches nothing else, but is not what the
# interface asks for. A PreparedRequest with its headers initialised
# the way prepare_headers would is, and costs the same.
req = PreparedRequest()
req.headers = CaseInsensitiveDict()
if client_id and client_secret:
HTTPBasicAuth(client_id, client_secret)(req)
req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
Expand Down