`fail-on-error` doesn't work well when download fails

[jsoref]

https://github.com/PowerDNS/pdns/actions/runs/19316037365/workflow?pr=16483#L116-L124

https://github.com/PowerDNS/pdns/actions/runs/19316037365/job/55247983411?pr=16483#step:12:145

github-action/action.yml

Line 68 in e988b39

fail-on-error:

Run coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b
```yml
  with:
    flag-name: auth-backend-remote
    path-to-lcov: $GITHUB_WORKSPACE/coverage.lcov
    parallel: true
    allow-empty: true
    fail-on-error: false
    github-token: ***
    coveralls-endpoint: https://coveralls.io/
    debug: false
    measure: false
    coverage-reporter-version: latest
    coverage-reporter-platform: auto-detect
  env:
    COMPILER: clang
    CLANG_VERSION: 13
    REPO_HOME: /__w/pdns/pdns
    BUILDER_VERSION: 0.0.0-git1
    COVERAGE: yes
    LLVM_PROFILE_FILE: /tmp/code-%p.profraw
    OPTIMIZATIONS: yes
    INV_CMD: . ${REPO_HOME}/.venv/bin/activate && inv
    BRANCH_NAME: 16483/merge
    normalized-branch-name: 16483-merge

Run # Enable debugging if 'debug' is true

github-action/action.yml

Lines 189 to 190 in e988b39

	echo "Failed to download coveralls binary or checksum (Linux)."
	[ "${{ inputs.fail-on-error }}" == "false" ] && exit 0

Failed to download coveralls binary or checksum (Linux).

github-action/action.yml

Lines 293 to 306 in e988b39

	- name: Coverage report
	if: inputs.parallel-finished != 'true'
	shell: ${{ startsWith(runner.os, 'Windows') && 'pwsh' || 'bash' }}
	run: >-
	coveralls report
	${{ inputs.debug == 'true' && '--debug' || '' }}
	${{ inputs.measure == 'true' && '--measure' || '' }}
	${{ inputs.fail-on-error == 'false' && '--no-fail' || '' }}
	${{ inputs.allow-empty == 'true' && '--allow-empty' || '' }}
	${{ inputs.base-path && format('--base-path {0}', inputs.base-path) || '' }}
	${{ inputs.build-number && format('--build-number {0}', inputs.build-number) || '' }}
	${{ inputs.format && format('--format {0}', inputs.format) || '' }}
	${{ inputs.file || inputs.path-to-lcov }}
	${{ inputs.files }}

Run coveralls report   --no-fail --allow-empty    $GITHUB_WORKSPACE/coverage.lcov 
/__w/_temp/16d91b4a-8e91-488a-abb2-9f38bdb90eed.sh: line 1: coveralls: command not found

[afinetooth]

Thanks @jsoref. We'll see how Copilot does on this, rather than wait until one of us has time to work on the fix.

Which might make this worth mentioning: We use Copilot Business, which ensures data privacy. LLMs are never trained on customer code—or any end user code at all, for that matter.

[jsoref]

It's pretty verbose. Personally, I'd have made a function to hide some of the verbosity:

quit() {
  if [ -n "$exit_without_failure" ]; then
    exit 
  fi
  exit $1
}

And then change all other instances of exit 1 to quit 1.

[afinetooth]

@jsoref I agree, but we'll stick with the verbosity to ensure readability. When we have more time, we can look at a refactor.

Would you like to test the new release v.2.3.7: https://github.com/coverallsapp/github-action/releases/tag/v2.3.7

I will point to this version in our CI as well to make sure all is well before we officially release or point @v2 to it.

[jsoref]

Merged in PowerDNS/pdns@2182d55 (and in the fork I use).

I'm not sure how easy it will be for me to spot this.

Some thoughts (in retrospect):

1. It'd be nice if it used a warning like:

   echo ::warning title=Coveralls::Failed to retrieve coveralls binary.

   As that'd surface the error on the summary page replacing
   
   as seen in https://github.com/PowerDNS/pdns/actions/runs/19316037365/attempts/1

2. If we do see and recognize a failure, I'll try to raise it here. But, hopefully we won't notice and w/o the other point, I'm not really sure we'll be able to notice.

[afinetooth]

(1) That is a great suggestion. I'll look into that as soon as I'm able.

(2) Thanks. That works.