Repository navigation
Android: fix firing urlRequest event for SPA navigations - #948
Open
strumasoft wants to merge 1 commit into
Open
strumasoft wants to merge 1 commit into
strumasoft wants to merge 1 commit into
Conversation
…navigations for urlRequest event
strumasoft
changed the title
strumasoft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android: Override shouldOverrideUrlLoading to handle history and SPA navigations for urlRequest event
History
urlRequest event handlers are not fired as described in web view documentation https://docs.coronalabs.com/api/library/native/newWebView.html when history.pushState, history.replaceState, hash changes (#section), or single-page-app (SPA) navigations/routing is used.
Solution
The existing code only implements shouldOverrideUrlLoading(WebView, String), but from API 24, WebView calls shouldOverrideUrlLoading(WebView, WebResourceRequest) instead, which just forwards to the old one, but now SPA navigations/routings are correctly fired as urlRequest events