docs: Update README regarding setuid and user namespaces - #790
Closed
maruixin-kls wants to merge 1 commit into
Closed
maruixin-kls wants to merge 1 commit into
maruixin-kls wants to merge 1 commit into
Conversation
smcv
requested changes
Sep 14, 2026
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
No, the paragraph you're deleting is still true, and is important contextual information.
Historically, bubblewrap did support being setuid root, and this has had a significant impact on its design. The fact that this is no longer available/supported doesn't change the fact that older versions of bubblewrap did have this behaviour.
In particular, this means that bubblewrap must continue to "fail closed" if someone mistakenly makes it setuid.
Collaborator
|
#743 is specifically about the "Related project comparison: xxx" sections of the readme, which weren't altered by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
The README currently contains outdated information suggesting that
setuidis the primary method for operation. This PR updates the text to clarify thatbubblewrapnow primarily relies on unprivileged user namespaces, aligning the documentation with the current implementation.