Repository navigation
update containerd (2.4.2), BuildKit (0.34.1), RootlessKit (3.3.0), CI deps - #5298
Merged
Merged
Conversation
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
revive v1.17.1 started flagging 6 literals in mod/tigron that it used to miss. Name the row decoration width in the table formatter, and allow the remaining quarter fractions and line separators, which naming would not make clearer. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
ktock
approved these changes
Oct 28, 2026
AkihiroSuda
commented
Oct 28, 2026
BuildKit v0.34 added a `src` option to the local and tar exporters (moby/buildkit#7226). Until then the local exporter dropped the unrecognized attribute, so the `src=/go/src/logger/logger` passed here was a no-op: that path exists in the builder stage, not in the exported `FROM scratch` stage, whose root holds just `/logger` -- which is what the test consumes as `binary://<temp>/logger`. Now that the option is honored, the export fails with "failed to solve: src=/go/src/logger/logger: no such file or directory". Drop it, which is exactly what the exporter did before v0.34. Verified rootless, running the test itself: it fails as above against BuildKit v0.34.1 and passes there without `src`, while pre-0.34 BuildKit passes either way. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.