Skip to content

test(windows): do not run TestNetworkInspectWithContainers in parallel #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 1 commit into from
Oct 27, 2026
+10 −23
Merged

test(windows): do not run TestNetworkInspectWithContainers in parallel #5269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions cmd/nerdctl/network/network_inspect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,19 +303,20 @@ func TestNetworkInspectByID(t *testing.T) {
func TestNetworkInspectWithContainers(t *testing.T) {
testCase := nerdtest.Setup()

// On Windows, containers on freshly created nat networks race with each other in HNS
// (hcnCreateNetwork: "The object already exists", https://github.com/containerd/nerdctl/issues/4322).
// Do not run the subtests, or other tests, in parallel with them.
noParallel := runtime.GOOS == "windows"
testCase.NoParallel = noParallel

testCase.SubTests = []*test.Case{
{
NoParallel: noParallel,
Description: "Verify that only active containers appear in the network inspect output",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("nginx-network-1"))
helpers.Ensure("network", "create", data.Identifier("nginx-network-2"))

// See https://github.com/containerd/nerdctl/issues/4322
// Maybe network create on windows is asynchronous?
if runtime.GOOS == "windows" {
time.Sleep(time.Second)
}

helpers.Ensure("create", "--name", data.Identifier("nginx-container-1"), "--network", data.Identifier("nginx-network-1"), testutil.NginxAlpineImage)
helpers.Ensure("create", "--name", data.Identifier("nginx-container-2"), "--network", data.Identifier("nginx-network-1"), testutil.NginxAlpineImage)
helpers.Ensure("create", "--name", data.Identifier("nginx-container-on-diff-network"), "--network", data.Identifier("nginx-network-2"), testutil.NginxAlpineImage)
Expand Down Expand Up @@ -348,17 +349,12 @@ func TestNetworkInspectWithContainers(t *testing.T) {
},
},
{
NoParallel: noParallel,
Description: "Display containers belonging to multiple networks in the output of nerdctl network inspect",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("network-1"))
helpers.Ensure("network", "create", data.Identifier("network-2"))

// See https://github.com/containerd/nerdctl/issues/4322
// Maybe network create on windows is asynchronous?
if runtime.GOOS == "windows" {
time.Sleep(time.Second)
}

containerID := helpers.Capture("run", "-d", "--name", data.Identifier(), "--network", data.Identifier("network-1"), "--network", data.Identifier("network-2"), testutil.CommonImage, "sleep", nerdtest.Infinity)

data.Labels().Set("containerID", strings.Trim(containerID, "\n"))
Expand All @@ -383,17 +379,12 @@ func TestNetworkInspectWithContainers(t *testing.T) {
},
},
{
NoParallel: noParallel,
Description: "Display only containers attached to the specific network",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("some-network"))
helpers.Ensure("network", "create", data.Identifier("some-network-as-well"))

// See https://github.com/containerd/nerdctl/issues/4322
// Maybe network create on windows is asynchronous?
if runtime.GOOS == "windows" {
time.Sleep(time.Second)
}

helpers.Ensure("run", "-d", "--name", data.Identifier(), "--network", data.Identifier("some-network-as-well"), testutil.CommonImage, "sleep", nerdtest.Infinity)
},
Cleanup: func(data test.Data, helpers test.Helpers) {
Expand All @@ -415,15 +406,11 @@ func TestNetworkInspectWithContainers(t *testing.T) {
},
},
{
NoParallel: noParallel,
Description: "Test container network details",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("test-network"))

// See https://github.com/containerd/nerdctl/issues/4322
if runtime.GOOS == "windows" {
time.Sleep(time.Second)
}

// Create and start a container on this network
helpers.Ensure("run", "-d", "--name", data.Identifier("test-container"),
"--network", data.Identifier("test-network"),
Expand Down
Loading