Repository navigation
fix: allow removing containers without network annotations - #5211
Merged
AkihiroSuda merged 1 commit intoSep 17, 2026
Merged
AkihiroSuda merged 1 commit into
AkihiroSuda merged 1 commit into
Conversation
Arman16-1998
force-pushed
the
fix/cri-rm-missing-network-annotations
branch
from
September 16, 2026 07:27
802006b to
7dcd9c6
Compare
AkihiroSuda
reviewed
Sep 16, 2026
| testCase.Run(t) | ||
| } | ||
|
|
||
| func TestRemoveContainerWithoutNetworkAnnotation(t *testing.T) { |
Member
There was a problem hiding this comment.
You can use an actual Kubernetes cluster for testing
nerdctl/cmd/nerdctl/container/container_commit_linux_test.go
Lines 31 to 55 in b24110c
AkihiroSuda
reviewed
Sep 16, 2026
| testCase.Run(t) | ||
| } | ||
|
|
||
| func TestRemoveContainerWithoutNetworkAnnotation(t *testing.T) { |
Member
There was a problem hiding this comment.
The test needs comment lines to explain the context
AkihiroSuda
reviewed
Sep 16, 2026
Signed-off-by: Arman Balian <arman.blain16@gmail.com>
Arman16-1998
force-pushed
the
fix/cri-rm-missing-network-annotations
branch
from
September 16, 2026 11:56
130e5bf to
8acf877
Compare
Author
|
@AkihiroSuda Updated the regression test to use a Kubernetes-created CRI container, added context comments, isolated the test namespace, and squashed the commits. CI has been rerun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5207
Removing stopped CRI-created containers could fail when their OCI spec did not contain the nerdctl/networks annotation.
NetworkOptionsFromSpec errors are now treated as non-fatal during removal, preserving the previous behavior while keeping port mapping cleanup for containers with valid nerdctl network metadata.
A regression test was added to verify that a container can still be removed after the network annotation is absent.