Repository navigation
fix: match ps --filter keys exactly instead of by prefix - #5197
Merged
AkihiroSuda merged 1 commit intoSep 11, 2026
Merged
Conversation
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-ps-filter-prefix-match
branch
from
September 9, 2026 17:00
0f70e24 to
19f87a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nerdctl ps --filtermatches the filter key withstrings.HasPrefix, so any key that starts with a supported one gets misrouted:--filter labels=envruns aslabel=env,--filter name2=fooasname=foo.Docker rejects these, and nerdctl already rejects other unknown filters like
driver=xFix: split on
=once and match the key exactly.Unknown keys hit the existing
invalid filtererror.Valid filters (
label=k=vincluded) are unchangedRepro before this change:
nerdctl: prints f1, exit 0
docker:
invalid filter 'labels', exit 1