Skip to content

fix: suppress spurious hostsstore NotFound warning on container removal #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 1 commit into from
Aug 1, 2026
Merged

fix: suppress spurious hostsstore NotFound warning on container removal #5098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/cmd/container/remove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,11 @@ func RemoveContainer(ctx context.Context, c containerd.Container, globalOptions
hs, err := hostsstore.New(dataStore, containerNamespace)
if err != nil {
log.G(ctx).WithError(err).Warnf("failed to instantiate hostsstore for %q", containerNamespace)
} else if err = hs.Delete(id); err != nil {
} else if err = hs.Delete(id); err != nil && !errors.Is(err, store.ErrNotFound) {
// De-allocate hosts file - soft failure
// Some platforms and network modes never allocate a hosts file for the container in the first
// place (e.g. Windows containers), so ignore NotFound errors here, similarly to the
// nameStore.Release call above.
log.G(ctx).WithError(err).Warnf("failed to remove hosts file for container %q", id)
}

Expand Down
Loading