Skip to content

Refactor container_list_test.go to use Tigron - #4641

Merged
AkihiroSuda merged 1 commit into
mainfrom
dev-4613
Dec 8, 2025
Merged

AkihiroSuda merged 1 commit into
mainfrom
dev-4613

Conversation

@AkihiroSuda

Copy link
Copy Markdown
Member

Updates tests to use nerdtest.Setup and the Tigron testing framework as per issue #4613.


Used Gemini, with the following prompt

Work on https://github.com/containerd/nerdctl/issues/4613 for @cmd/nerdctl/container/container_list_test.go .

- Try to preserve the original test structure as much as possible.
- In Tigron, `t.Parallel()` does not need to be explicitly set. Refer to @docs/testing/tools.md for further information about Tigron.
- To run a test, use `go test -exec sudo -run <TESTNAME> <PACKAGE>`.

Updates tests to use nerdtest.Setup and the Tigron testing framework
as per issue #4613.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v2.2.1 (?) milestone Dec 8, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Dec 8, 2025

@ChengyuZhu6 ChengyuZhu6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
AkihiroSuda merged commit de8b1c9 into main Dec 8, 2025
36 checks passed
@AkihiroSuda
AkihiroSuda deleted the dev-4613 branch December 8, 2025 06:46
ogulcanaydogan added a commit to ogulcanaydogan/nerdctl that referenced this pull request May 14, 2026
Replace testutil.NewBase with nerdtest.Setup throughout
multi_platform_linux_test.go, following the Tigron framework
pattern (containerd#4641).

Changes:
- Use nerdtest.RegistryWithNoAuth instead of testregistry.NewWithNoAuth
- Use data.Temp().Save() for Dockerfiles and compose files
- Convert testMultiPlatformRun helper to use test.Helpers
- Use SubTests in TestMultiPlatformRun for per-platform isolation
- Register builder cache cleanup in Cleanup callbacks
- Add requireMultiPlatformExec requirement using platformutil

Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
ogulcanaydogan added a commit to ogulcanaydogan/nerdctl that referenced this pull request Jun 7, 2026
Replace testutil.NewBase with nerdtest.Setup throughout
multi_platform_linux_test.go, following the Tigron framework
pattern (containerd#4641).

Changes:
- Use nerdtest.RegistryWithNoAuth instead of testregistry.NewWithNoAuth
- Use data.Temp().Save() for Dockerfiles and compose files
- Convert testMultiPlatformRun helper to use test.Helpers
- Use SubTests in TestMultiPlatformRun for per-platform isolation
- Register builder cache cleanup in Cleanup callbacks
- Add requireMultiPlatformExec requirement using platformutil

Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants