Repository navigation
[CI]: tests cleanup - #4247
Merged
Merged
[CI]: tests cleanup#4247
Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
marked this pull request as ready for review
May 15, 2025 18:09
apostasie
commented
May 15, 2025
| }, | ||
| Cleanup: func(data test.Data, helpers test.Helpers) { | ||
| helpers.Anyhow("rmi", "-f", data.Identifier("ignored")) | ||
| helpers.Anyhow("rmi", "-f", data.Identifier()) |
Contributor
Author
There was a problem hiding this comment.
Properly remove leftovers.
apostasie
commented
May 15, 2025
| data.Labels().Set("containerName1", data.Identifier("-container1")) | ||
| containerName1 := data.Labels().Get("containerName1") | ||
| helpers.Ensure("run", "-d", "--name", containerName1, | ||
| data.Labels().Set("container1", data.Identifier("container1")) |
Contributor
Author
There was a problem hiding this comment.
There is no need for "-" in suffix - this is added automatically by Identifier
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
2025-05-net-test-cleanup
branch
from
May 15, 2025 18:15
28a3d08 to
d9cf528
Compare
apostasie
commented
May 15, 2025
| helpers.Anyhow("rm", "--data-root", data.Temp().Path(), "-f", data.Identifier()) | ||
| }, | ||
| Command: func(data test.Data, helpers test.Helpers) test.TestableCommand { | ||
| return helpers.Command("run", "--data-root", data.Temp().Path(), "--rm", "--name", data.Identifier(), "-p", "22200-22299:22200-22299", testutil.CommonImage) |
Contributor
Author
There was a problem hiding this comment.
Name is useless here, and so is cleanup.
apostasie
commented
May 15, 2025
| data.Labels().Set("container2", data.Identifier("container2")) | ||
| nerdtest.EnsureContainerStarted(helpers, data.Identifier("container2")) | ||
| }, | ||
| Expected: func(data test.Data, helpers test.Helpers) *test.Expected { |
Contributor
Author
There was a problem hiding this comment.
Splitting this into subtests.
apostasie
commented
May 15, 2025
| return &test.Expected{ | ||
| ExitCode: 0, | ||
| } | ||
| return helpers.Command("run", "--rm", "--uts", "host", |
apostasie
commented
May 15, 2025
| return &test.Expected{ | ||
| ExitCode: 1, | ||
| } | ||
| return helpers.Command("run", "--rm", "--dns", "0.1.2.3", |
apostasie
commented
May 15, 2025
| ExitCode: 1, | ||
| } | ||
| }, | ||
| // 1 for nerdctl, 125 for docker |
Contributor
Author
There was a problem hiding this comment.
Unless aligning with docker on exit codes would really matter to us, simplifying.
Contributor
Author
|
Failures:
|
Contributor
Author
|
Failure is #4249 |
Contributor
Author
|
Failure is Hub 429. |
Contributor
Author
|
Green. |
Contributor
Author
|
Green again. |
Contributor
Author
|
Green. I think we can call it and merge - then close the issues linked above. |
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tentative at fixing:
The hypothesis is that in very slow environments (eg: EL8 under pressure), containers started with
-dmay not have started by the time we are testing on them, resulting in unspecified behavior (whether this is a bug or not is a separate conversation to be evaluated case by case).Besides enforcing verification that the container has started, this PR does take the occasion to do some cleanup:
-dwhen not necessaryCommonImageinstead of Alpine, or Nginx (when not necessary)WithArguments, simplify expectations)I will restart the CI a few times to confirm that EL8 is no longer failing on these.