Skip to content

[CI]: rewrite logs tests - #4209

Merged
AkihiroSuda merged 2 commits into
containerd:mainfrom
apostasie:2025-05-fix-logs-test
May 20, 2025
Merged

AkihiroSuda merged 2 commits into
containerd:mainfrom
apostasie:2025-05-fix-logs-test

Conversation

@apostasie

@apostasie apostasie commented May 7, 2025 •

Copy link
Copy Markdown
Contributor

Commit 1 relaxes RunSigProxy refresh frequency.
Suspicion is that currently this is putting extra pressure on the runtime - especially for slow environments like EL.

Commit 2 rewrites all remaining logs tests with the new framework.

IMPORTANT NOTES:

Note that while torturing tests, the following issues showed-up:

Because of these, logs tests may/will fail randomly.

@apostasie apostasie changed the title [CI]: fix logs tests issues [WIP] [CI]: fix logs tests issues May 7, 2025
@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch 16 times, most recently from 451d61a to 55da1df Compare May 9, 2025 22:40
@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch 7 times, most recently from 9f07391 to ef8c1b5 Compare May 10, 2025 23:23
@apostasie apostasie closed this May 11, 2025
@apostasie apostasie reopened this May 11, 2025
@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch 2 times, most recently from df306c5 to a3388e7 Compare May 11, 2025 03:06
@apostasie apostasie closed this May 11, 2025
@apostasie apostasie reopened this May 11, 2025
@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch from a3388e7 to c03cdf3 Compare May 13, 2025 05:58
@apostasie apostasie closed this May 13, 2025
@apostasie apostasie reopened this May 13, 2025
@apostasie apostasie changed the title [WIP] [CI]: fix logs tests issues [CI]: rewrite logs tests May 14, 2025
@apostasie
apostasie marked this pull request as ready for review May 14, 2025 15:53
@apostasie

apostasie commented May 14, 2025 •

Copy link
Copy Markdown
Contributor Author

I have been sitting on this for a bit, as I couldn't make logs to work perfectly locally (see tickets), but I think it is time to merge and bring all logs tests to the new testing framework.

Worse case scenario, we flag them "flaky" and they go back to the retry bucket.

Poking @AkihiroSuda @fahedouch

@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch from c03cdf3 to aab31dc Compare May 14, 2025 16:00
@apostasie

Copy link
Copy Markdown
Contributor Author

Rebased for good measure.

@apostasie

Copy link
Copy Markdown
Contributor Author

Failures unrelated.

@AkihiroSuda AkihiroSuda added this to the v2.1.2 milestone May 15, 2025
@AkihiroSuda
AkihiroSuda requested a review from fahedouch May 17, 2025 09:39
apostasie added 2 commits May 17, 2025 12:13
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
apostasie force-pushed the 2025-05-fix-logs-test branch from aab31dc to 8bd7a7d Compare May 17, 2025 19:13
@apostasie

Copy link
Copy Markdown
Contributor Author

Rebased.

@apostasie

Copy link
Copy Markdown
Contributor Author

Failure is #4243

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
AkihiroSuda merged commit 82cdd40 into containerd:main May 20, 2025
@fahedouch

Copy link
Copy Markdown
Member

thanks @apostasie

Sorry for the delay, I was sick for the last two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI]: TestLogsWithoutNewlineOrEOF flaky

3 participants