Repository navigation
[CI]: rewrite logs tests - #4209
Merged
Merged
Conversation
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
16 times, most recently
from
May 9, 2025 22:40
451d61a to
55da1df
Compare
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
7 times, most recently
from
May 10, 2025 23:23
9f07391 to
ef8c1b5
Compare
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
2 times, most recently
from
May 11, 2025 03:06
df306c5 to
a3388e7
Compare
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
from
May 13, 2025 05:58
a3388e7 to
c03cdf3
Compare
apostasie
marked this pull request as ready for review
May 14, 2025 15:53
Contributor
Author
|
I have been sitting on this for a bit, as I couldn't make logs to work perfectly locally (see tickets), but I think it is time to merge and bring all logs tests to the new testing framework. Worse case scenario, we flag them "flaky" and they go back to the retry bucket. Poking @AkihiroSuda @fahedouch |
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
from
May 14, 2025 16:00
c03cdf3 to
aab31dc
Compare
Contributor
Author
|
Rebased for good measure. |
Contributor
Author
|
Failures unrelated. |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
2025-05-fix-logs-test
branch
from
May 17, 2025 19:13
aab31dc to
8bd7a7d
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
Failure is #4243 |
Member
|
thanks @apostasie Sorry for the delay, I was sick for the last two days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1 relaxes RunSigProxy refresh frequency.
Suspicion is that currently this is putting extra pressure on the runtime - especially for slow environments like EL.
Commit 2 rewrites all remaining logs tests with the new framework.
IMPORTANT NOTES:
-d, as this is a significant source of flakyness - if this is not acceptable and we do believe that all these tests must be run with-d, let me know and I will come up with something elseNote that while torturing tests, the following issues showed-up:
Because of these, logs tests may/will fail randomly.