Skip to content

CI: icmd is not usable to test when binary expect a console #3883

Closed

Description

@apostasie

Description

icmd passes an io.Multiwriter for stdout and stderr of the underlying command.

So (even if stdout is a proper pty), the command will still bail out if it requires a console (because "inappropriate ioctl for device").

That, along with the gymnastic in containerd/console - took me half a day to figure out why the eff I would not get anything on out with attach tests.

I am not sure we should continue using icmd.
The added value of it is rather limited (literally a few dozens lines of code that we are still using) , and I am not particularly interested in going over there to hack on it.

I will bypass it so that we can get #3591 in either way, so, might be time to bite the bullet and ditch it.

Steps to reproduce the issue

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

Activity

  1. apostasie commented on Mar 5, 2025

    @apostasie
    ContributorAuthor

    /dibs

    I'll get us away from icmd once I am done with the CI-build series.

    @AkihiroSuda can you assign?

  2. apostasie commented on Mar 20, 2025

    @apostasie
    ContributorAuthor

    @fahedouch can you slate this for milestone 2.x.x?

  3. added this to the v2.x.x milestone on Mar 20, 2025
  4. modified the milestones: v2.x.x, v2.0.5 on Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/cie.g., CI failurebugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions