Skip to content

A Lens's review that ends while a conflict waits at the Run ceiling holds the item, and the explorer reads a conflict at once (#811) - #858

Open
don-petry wants to merge 4 commits into
mainfrom
kernel/explorer-conflict-at-once-811
Open

don-petry wants to merge 4 commits into
mainfrom
kernel/explorer-conflict-at-once-811

Conversation

@don-petry

@don-petry don-petry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Closes #811.

What.

  • The new move. The transitions explorer gains the move trial P-40 showed (trials/P-40.at-once.json): a conflict read straight after a head that merges, with no unknown between, taking the item out of the queue as the slow move does.
  • What it finds. Two moves deep the explorer then reaches addressing -> held by a Lens, bound max_runs_per_item. The case: an item at the Run ceiling with a review Run in flight reads addressing once the conflict is read. When the Lens's review passes, the Run ceiling holds it (conflict -> run_ceiling).
  • Why it is declared, not changed. The Kernel already made this Hold three moves deep, through unknown, so it is a real gap in the Lifecycle and not something the move creates. It is declared beside the same Hold by the Factory and by the platform: a ruled change, with a decision record.
  • No twin at the bound apart. A Lens's review that passes spent model time, so it is never counted apart (decision 0202), and only a Factory Run reaches that bound.

Record 0221, the number the Factory Builder gave it in the chain. It stays red on the record gap until 0211 to 0220 land.

Protected edit: lifecycle/pull_request.json, the one transition declared. Pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder.

Tests and mutants.

  • tests/test_transitions.py::test_a_conflict_worked_out_at_once_is_explored: written first, with the move in, and test_a_hold_no_person_makes_names_what_bounds_it failed as the issue says. It walks both ways to the Hold, at once and through unknown, with the same readings. From the one base it explores with and without the move, and only the move reaches the Hold two moves deep.
  • tools/mutants.py gains two mutants:
    • "the Run ceiling's Hold a Lens's review makes from addressing is undeclared";
    • "the explorer reads a conflict only through unknown".
  • All 108 mutants of the three files this touches are killed. tests.test_transitions passes, and make checks passes but for the record gap.

Readers (head 46d632c):

Reader Findings Disposition
Claude review 1 minor, 1 info The minor is the provisional number's gap, settled at enqueue. The info: the test kept only the first example of the Hold, and now explores the base with and without the move (801f793)
Claude security none —
Astra (gpt-6-astra) none —
Kimi (kimi-k3.1-pro) Kimi: 0 findings, 0 taken —
Muse no read: the answer came back empty twice, on muse-wonder-full-1.0 and on muse-wonder-1.0 Owed
Carbon (gemini-4-carbon-high) not run (quota) Owed

🤖 Generated with Claude Code

don-petry and others added 2 commits November 13, 2026 12:13
…olds the item, and the explorer reads a conflict at once (#811, record 0220 provisional)

The explorer gains the move P-40 showed: a conflict read straight after a head that merges, with no unknown
between. Two moves deep it then reaches addressing -> held by a Lens at max_runs_per_item, which the Kernel
already made three moves deep and the Lifecycle did not declare. Declared, a ruled change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…thout the move, not the first example kept

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 13, 2026 18:23
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T18:23:55.995707Z
We couldn’t complete this review. Comment @codex review to try again.
801f793 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #31f7e Reviewed your PR 801f793 Nov 13, 2026 · 18:24 18:30

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request documents and implements a new transition where a Lens's review ending while a conflict waits at the Run ceiling holds the item. It updates lifecycle/pull_request.json to declare the addressing -> held transition by a lens bound by max_runs_per_item, and adds a new transition move and test in tests/test_transitions.py to handle immediate conflicts. Feedback was provided to address a PEP 8 line length and indentation violation in the new test code by refactoring the dictionary creation.

Comment thread tests/test_transitions.py Resolved
don-petry and others added 2 commits November 13, 2026 12:25
)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its own

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/decisions/0221-a-lens-review-that-ends-while-a-conflict-waits-at-the-run-ceiling-holds-the-item-and-the-explorer-reads-a-conflict-at-once.md">

<violation number="1" location="docs/decisions/0221-a-lens-review-that-ends-while-a-conflict-waits-at-the-run-ceiling-holds-the-item-and-the-explorer-reads-a-conflict-at-once.md:1">
P2: This `0221` record makes the decision check fail while 0211–0220 are absent. Add the preceding records before this record is checked, or defer 0221 until they land.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@@ -0,0 +1,21 @@
# 0221. A Lens's review that ends while a conflict waits at the Run ceiling holds the item, and the explorer reads a conflict at once

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This 0221 record makes the decision check fail while 0211–0220 are absent. Add the preceding records before this record is checked, or defer 0221 until they land.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At docs/decisions/0221-a-lens-review-that-ends-while-a-conflict-waits-at-the-run-ceiling-holds-the-item-and-the-explorer-reads-a-conflict-at-once.md, line 1:

<comment>This `0221` record makes the decision check fail while 0211–0220 are absent. Add the preceding records before this record is checked, or defer 0221 until they land.</comment>

<file context>
@@ -0,0 +1,21 @@
+# 0221. A Lens's review that ends while a conflict waits at the Run ceiling holds the item, and the explorer reads a conflict at once
+
+Status: accepted. The Factory Builder's ruling of 2026-11-13 on "The transitions explorer reads a conflict only two moves after a head that merges, and one move finds a Hold the Lifecycle does not declare" (issue 811): a real gap in the Lifecycle is declared, a ruled change. Trial P-40 found it ("Trial P-40: a move of the base alone makes GitHub work out mergeable again, for a pull request that still merges and for one the move makes conflict", issue 809), and record 0214 left it out by name.
</file context>

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

1 code suggestion

1. The starting item has queue=False, and this checks only state and reason, so it never verifies that a queued conflict is ejected.

Incomplete implementation · tests/test_transitions.py:1094

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 2bdaac8468dc

@don-petry

Copy link
Copy Markdown
Contributor Author

Carbon (gemini-4-carbon-high, head 2bdaac8): a clean read, no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The transitions explorer reads a conflict only two moves after a head that merges, and one move finds a Hold the Lifecycle does not declare

1 participant