Repository navigation
The release step keeps its own exchanges, held to lists, as a public artifact of its run (record 0176) - #689
Conversation
…artifact of its run (#531) release/exchanges.py's Recording wraps the step's one transport and keeps each exchange it sends through RELEASE_TOKEN: the call, its Accept, the headers a trial's fixture keeps but location, and of a JSON body only the fields FIELDS names. An artifact's download, a file read at a commit and any body that is not JSON are kept as their size and sha256 alone. tools/redact_trial.py's redact_json then takes out anything shaped like a credential, as from a trial's capture. A fault in keeping drops that exchange and never changes the step. release/move.py keeps them where RELEASE_EXCHANGES names a folder, and writes the file in a finally, whatever stopped the step; it prints what it printed before. release.yml names the folder, ${{ github.workspace }}, and its last step, if: always(), uploads release-exchanges.json as the one artifact release-exchanges for 90 days. The shape rules, five counter-examples, the release-exchanges/1 schema, 8 tests and 14 mutants hold it. The record is NNNN until the Factory Builder numbers it. The release.yml edit was pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lds its rule within 40 lines (#531) Two mutants survived: a download kept whole, since a text body is measured anyway, and a file written over, since open's "x" refuses one. The leak test now has a download the storage answers as JSON, kept by its measure alone; the exists() check, which "x" already does, is gone, and the mutant writes with "w". release/AGENTS.md gains one row for the exchanges and merges two of the tag rows to stay at 40 lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…held to the lists; a file is measured as itself (#531) The security pass and the Claude review of 1c71084: - The step writes release-exchanges.json at the checkout's root. One a commit carried would stand there first, the write would refuse it, and the upload would publish it, or what a link points at, in place of the step's record. tools/check_repo.py now refuses that path at the root, so no such commit passes verify to reach main. - A request's own body and headers are held to the lists as an answer's are, and each field left out is named in dropped; a test now sends both. - An opaque answer with no body wrote "measured": null, which its schema refuses; it is now left out. - A file read at a commit is measured as its own bytes, decoded from GitHub's base64, not as GitHub's JSON around it, so a fixture can hold it to the file. Six mutants, and the record's rows say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ording a step, always written (#531) Argon's and Muse's reads of fcfbfc3: - A text in a list no field names, or a body that is a bare value, was kept whole (Muse). Now a text, a number or a truth is kept only under a field FIELDS names; anything else is left out and its place named. - move.py made a recording for each transport, which a second could not write over (Argon). Now one recording serves the step, and it writes its file even where the step stopped before it connected. - A header's name kept its spaces, and an Accept not given was written as null (Argon). - A place left out was named though its exchange was not kept (Argon). - No test held that a left-out field's name is written only as a plain identifier, or that a relative folder is refused (Muse). Each with a test and a mutant; three mutants re-pointed to the lines that moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…der gave it at enqueue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The rename to 0176 was committed, but not the title's own number, which still read NNNN: check_context in CI refused it, as it read the commit where the local checks read the working tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Closes #531, "The release step records its own exchanges, redacted, after factory/v0.1.0".
The edit to
.github/workflows/release.ymlwas pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder. The design was approved on 2026-11-09 with three rulings:tools/redact_trial.py, don't copy it;The record is 0176, the number the Factory Builder gave at enqueue;
mainis merged in.What it does
release/exchanges.py'sRecordingwraps the release step's one transport. It keeps each exchange the step sends throughRELEASE_TOKEN, and passes every request through unchanged. The file becomes an artifact of a public repo, so what is kept is held to lists, and anything not on them is left out and its place named indropped:tools/check_trials.py'sHEADERSlets a trial's fixture keep, butlocation, a redirect's addressFIELDSnames, at any depth; a text, a number or a truth only under such a fieldtools/redact_trial.py'sredact_json, the trials' own redactionKeeping never changes the step. A fault drops that exchange and is counted in
unkept.release/move.pywrites the file in afinally, whatever stopped the step, and prints what it printed before.release.yml:RELEASE_EXCHANGES: ${{ github.workspace }};if: always(), that uploadsrelease-exchanges.jsonas the one artifactrelease-exchanges, kept 90 days. Nothing prints it.tools/check_repo.pyrefuses that file at the checkout's root, so a committed one can never stand there first and be uploaded in place of the step's own record.The rulings' conditions on the import:
release.exchangesstarts no process and opens nothing but modules, held by an audit-hook test.tests/test_tools.py'sSHAPEDthrough it.Held by
tests/test_release_exchanges.pyhas 15, andtests/test_tools.pyone more for the root file.tools/check_workflows.py's rules forrelease.yml, with six counter-examples:with:on the step.release-exchanges/1(schemas/release-exchanges.schema.json), with an example and a counter-example.tools/check_workflows.py's re-pointed to lines this change moved. Every mutant ofrelease/exchanges.pyandrelease/move.pyis killed by the tests it names alone.docs/decisions/0176-the-release-step-keeps-its-own-exchanges-held-to-lists-as-a-public-artifact-of-its-run.md, and a row inrelease/AGENTS.md.Checks
make verifyon an export of the head,8057b8e(treea7e3ecd): running; the result is added below when it ends.release/exchanges.pyandrelease/move.py, 46 in all, is killed by its named tests alone; 41 of them were also run bytools.mutantsand killed.Reads
Argon and Muse read
fcfbfc3; the Claude review and the security pass read1c71084. The fix round after them,d71ec66, answers their findings, and no reader read it again. The merge ofmainand the numbering change nothing of this PR's own.fcfbfc3fcfbfc31c710841c71084release/move.py:181release/exchanges.py:74release/exchanges.py:105release/exchanges.py:71release/exchanges.py:69release/exchanges.py:133release/exchanges.py:50release/exchanges.py:62release/exchanges.py:98release/exchanges.py:105release/exchanges.py:39release/exchanges.py:128🤖 Generated with Claude Code