Repository navigation
The fake's merge queue merges on its required checks alone, as GitHub's does (#677) - #683
Conversation
… alone, with no pass read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ide the pass condition Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… merge, the ruling as the fixture's answer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s does (#677) GitHub's queue merged a queued pull request once its merge group's required check passed, with no pass of the Factory's read between (trials/P-2.no-pass.json). The fake now does the same: the rule a_pass_comes_before_the_merge, which it contradicted, becomes the_queue_merges_on_its_required_checks, grounded on that fixture. What a merge must carry (NFR-4, I-29/I-31, I-37, I-45) is held at the Factory's own enqueue, and at the merge only where a pass read the item as it was merged; a merge over what came after the last read is noted, never asserted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ad in another shape (#677) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d L-19 says what holds (#677) The reads of the fake's queue merging on its checks alone: the enqueue now checks every objection a pass would take a queued item out for, not only the approval, contract and review; I-37 and I-45 stay held at every merge, since a push takes the item out; a test forces each bad enqueue and mutants hold both sides. L-19 and sim/AGENTS.md say what the Factory holds: no enqueue without an approval of the content queued, and a pass that takes out one that lost it. The rule names P-2.queue-app for "whoever enqueued it". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A pass that reads the queued item still takes it out before it merges, which is what each row cites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
# Conflicts: # docs/architecture/software-factory-design.md # sim/grounding.py
|



Closes #677, "The fake's merge queue merges on its required checks alone, as GitHub's does (a_pass_comes_before_the_merge)". Stacked on #682, the P-2 no-pass trial, whose fixture
trials/P-2.no-pass.jsongrounds it. Thesim/edits are pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder.What changes
sim/world.py,platform()) merges a queued item once its required checks pass, with no pass read between, as GitHub's did in P-2's run (and for the queue App's enqueue intrials/P-2.queue-app.json).merged before a pass read …, never asserted.objections(), which covers the approval of this content by an approver who can write, a writer's thread or request for changes, a Hold, a failed check, an impostor check, the contract, its evidence and an unread description edit. I-37 and I-45 are held there too. This is where the guarantee the old merge gave now lives.a_pass_comes_before_the_merge, which the fake contradicted, becomesthe_queue_merges_on_its_required_checks, grounded ontrials/P-2.no-pass.jsonandtrials/P-2.queue-app.json. The port's contract lists it inNOT_READasshape: the trial read it by REST lists and a timeline query, not the facts port's rollup.sim/AGENTS.mdnow say what the Factory holds: nothing enters the queue without an approval of exactly the content queued, and one that loses it leaves at the next pass. L-19's Check names the new enqueue test.test_the_factorys_own_enqueue_holds_what_the_queue_merges_on_aloneforces each bad enqueue: no approval, a thread, a failed check, an unapproved contract, no review. It pins each one's reason.For the Factory Builder: NFR-4 has a window on GitHub
GitHub merges on required checks alone. A dismissal, Hold or thread made while an item is queued is honoured only if a pass dequeues it before the queue merges, which may be up to one poll interval later. So "every merge carries a standing approval" (NFR-4) cannot be met in full. L-19 now says so plainly.
Closing the window would need a required check of a Factory App on the merge group. Your ruling on #659 said that breaks §9.1's recovery rule, so this PR does not do it.
The first 40 seeds
SIM_SEEDS=40: every path is still reached, andtest_invariants_hold_under_faultsand the seed-coverage tests pass. Over the first 40 seeds at 250 steps, before the fix round, 5 merged: 1 after a pass read it and 4 with no read between, 2 of them over something unread.Checks
SIM_SEEDS=40 make verifysim/AGENTS.mdstated the old rule; the enqueue checks had no test or mutant; stale test commentssim/AGENTS.md; no tests for the new checks. Minor and nits fixed: grounding names P-2.queue-app; a mutant drops the success-only condition; I-37 and I-45 held at every mergeLabelled
factory:hands-off. Enqueue waits for the Factory Builder's all-clear. No record is added.🤖 Generated with Claude Code