Skip to content

Record the ruling on linting: the required check installs nothing - #54

Closed
don-petry wants to merge 4 commits into
mainfrom
docs/linting-ruling
Closed

don-petry wants to merge 4 commits into
mainfrom
docs/linting-ruling

Conversation

@don-petry

@don-petry don-petry commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What this is

The Maintainer's ruling of 2026-10-11, written into the design: the required check installs nothing, so no formatter, linter or type checker is a required check.

The design said "a type checker and a linter are required checks" (§9.12). Decision record 0014, on the pull request "Context for the Factory's authors: lessons, standards, decisions and the checks that hold them", says there is none, because each is an install and the required check runs only what is in the commit. The ruling is that 0014 stands.

What changed

  • §9.12, the row "Types as the code is written".
  • §9.1, the critical path, item 7: what lint means in this repo.

Part of the story "Land the authors' context: lessons, standards, decisions and the checks that hold them". Its other criterion on this ruling, the lint Lens in config/defaults.json, is left to that pull request, which already edits the configuration.

What is given up, and accepted

Types and style caught by standard tools. The repo's own checks and the mutation check stand in their place.

Verification

make verify passes. One document.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

The design said a type checker and a linter are required checks. The
decision record on the authors' context says there is none, because each is
an install and the required check runs only what is in the commit. The
Maintainer ruled on 2026-10-11 that the decision record stands.

The design's two lines now agree with it. What is given up, and accepted:
types and style caught by standard tools.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: combsmith/software-factory/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f4d0f0cc-edaa-4ee0-a4b8-388d60a14f19
📥 Commits

Reviewing files that changed from the base of the PR and between 9e976c2 and 48b58fe.

📒 Files selected for processing: 1
  • docs/architecture/software-factory-design.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai

codeant-ai Bot commented Oct 14, 2026

Copy link
Copy Markdown

CodeAnt PR Risk: Medium Risk

  • The PR needs a manual documentation check before approval.
  • Confirm that make verify and the claims about required checks and installed tools match the current repository setup.

Assessed commit: 79b593305100

The org was renamed to combsmith; GitHub Actions does not redirect uses: after a rename. Same rewrite as the org cutover, nothing else. This branch still conflicts with main for reasons unrelated to the rename.
@don-petry
don-petry requested a review from a team as a code owner October 14, 2026 15:01
Restores every other file to this branch's previous content, so the PR diff stays this PR's own change; its petry-projects references stay rewritten to combsmith.
Restores every other file to this branch's previous content, so the PR diff stays this PR's own change; its petry-projects references stay rewritten to combsmith.
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Superseded: the ruling is already on main. The pull request "Context for the Factory's authors" (#6) wrote it into §9.12 ("Types as the code is written") and §9.1 item 7, together with the Maintainer's later ruling of 2026-10-13 that SonarCloud reports and informs. This branch now only conflicts with that text.

@don-petry don-petry closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant