Repository navigation
The redactor reads a crafted capture in time, and SonarCloud's shell style rule is set aside for two scripts (#361) - #453
Conversation
…shell style rule is set aside for two scripts STATUS_LINE's reason phrase and its trailing space could both hold a space, so a status line with a long run of them and then what no status holds took time in its square: 2.8 s at 32,000 characters through the redactor, on a capture read before anyone has looked at it. The phrase now ends in no space. The language is the same, and a test holds both. S8786 on check_context's TITLE is declined where it stands: issue 369's test holds its CPU linear on the shape the rule fears. Issue 361's 43 findings are all shell:S7688, `[[` in place of `[`, style alone. The Factory Builder ruled they are set aside in sonar-project.properties for tools/context_eval.sh and tools/trial_as_app.sh, and neither script is edited: the second holds a credential's path, and CI cannot run it for real. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…line's test holds a hyphen The reads. `_credentials` read each key twice, and `shaped` reads what it decodes through `_credentials`, so the work doubled at each level of base64 inside a key while the text grew by a third: 5,600 characters took over four seconds. That is worse than the regex this pull request set out to fix, and it is on the same path. A key is now read once, with a test and a mutant. STATUS_LINE's test had no hyphen inside a phrase, so a mutant that dropped it survived. It has one now, with that mutant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
# Conflicts: # tools/mutants.py
…arallel run cannot remove it Every test of ReaderTrialScript cleans up what INSIDE names, and a mutant shard's baseline deals a class's methods to parts run at once. So another method's clean-up could remove `__pycache__/scratch-of-the-reader` while this test used it: mktemp failed, the script exited 1 and not 2, and the shard failed before any mutant ran, on no fault of the pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Answers #361 (SonarCloud: shell script hygiene) as the Factory Builder ruled, and, as additional work they asked for in the same pull request, two
python:S8786findings that no audit issue lists yet. The reads found a worse fault on the same path, and that is fixed too. No record; no Kernel code.tools/check_trials.py:214python:S8786tools/redact_trial.py:36STATUS_LINE's phrase and trailing space overlapped: 2.8 s at 32,000 characters. Linear now, and it accepts the same stringspython:S8786tools/check_context.py:53TITLEis linear on every shape tried, and issue 369's test holds thatshell:S7688(43)tools/context_eval.sh,tools/trial_as_app.shsonar-project.properties, with the reason beside it. Neither script is editedWhat #361's ruling departs from
Its acceptance asks for real fixes, with
NOSONARonly for a confirmed false positive. These 43 are style, not false positives. The Factory Builder ruled to set them aside becausetools/trial_as_app.shholds a credential's path and CI cannot run it for real. The ruling is recorded on #361.Not verified
NOSONARshows only in the scan after this merges. The rule key is the one SonarCloud's API reports.Checks
tests.test_tools.Verify,RedactionandMutantspass locally, 51 tests. The first version of SonarCloud: the schema patterns are held to a limit, one finding fixed and two declined (#360, #359) #451 (SonarCloud: the schema patterns are held to a limit) missedVerify, so these ran before pushing.STATUS_LINEaccepting the same language.make verifyandpython3 -m tools.mutants: CI'schecksjob and eight shards at this head. Neither ran whole at a desk; this is queued only if they are green.Reviews
All four reads ran on
542e93e; each finding was checked as data, with one fix round in046635d.ca4029balso fixes a race CI found in a test outside this change: everyReaderTrialScripttest removed a shared scratch directory, which could fail a mutant shard's baseline on any pull request.The security pass's subagent also ran a
pkill -fbroad enough to match other sessions' processes. It changed nothing here. The Factory Builder has been told, in case a sibling's job died.542e93e542e93e542e93e542e93etests/test_tools.py:6909sonar-project.properties:16tests/test_tools.py:6909tools/redact_trial.py:37tools/check_trials.py:214tools/redact_trial.py:91tools/redact_trial.py:184🤖 Generated with Claude Code