Repository navigation
Each job the Factory writes stops its own work under a step limit, so a job too long fails and is never cancelled (#388, record 0098) - #434
Conversation
… a job too long fails and is never cancelled (#388) GitHub concludes a job it stops at its own timeout cancelled, its check run with it (P-42); a step stopped at its own limit concludes failure, its job with it (P-42.step-timeout). So check_workflows' timeout rule now holds each run: step to a timeout-minutes of its own, and a job's run: steps to fewer minutes together than the job. Every workflow, its templates, its shape checks, the example, the standard's copy and the counter-examples carry the limits; ci.yml's hash is recorded again. The design's 4.2 and 3.10 say what a timeout concludes, and P-18's row which part P-42 answered. The sim's killed Run concludes failure, or cancelled with no outcome, never timed_out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n for a job's other steps, the checks job given 28 The run: steps' limits together now leave their job MARGIN, two minutes, for its set-up, uses: and post steps, which took at most 8 s in 116 jobs of the required checks' runs. make verify took up to 23 minutes, so the checks job has 28 and its step 26. The eval job keeps its 120 minutes and BUDGET; its run step has 110, within which its cases end. The standard says the margin, and a counter-example leaves a job less than it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…step's limit holds what its step needs The Claude review and the security pass: timeout-minutes: 0 sets no limit, and a digit int() reads but YAML does not crashed or passed the check; a limit is now MINUTES, [1-9][0-9]*, with a counter-example. The Claude review: no test tied the eval run step to BUDGET or the Engine step to the longest tier; one does, with a mutant each. The design says the guarantee holds while a job's other steps keep within the margin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…code has it, and the record is 0098 The Factory Builder's ruling, option A. The Claude review found that apply leaves environment, run_failed, for any run job that did not succeed, so a Run past its limit was never an attempt. The code stays. Section 3.10, the record and the sim's comment say so, and issue 433 asks whether it should count, and what that needs from the run job. The record is renumbered 0098. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…-caee96 # Conflicts: # tools/mutants.py
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ts limit The merge group ejected this: four form counter-examples that #428 (Workflow check: a list under on: is one only where its events begin with an item) landed have run: steps with no limit, so each broke the timeout rule beside its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|



Closes #388. Record 0098, which builds on 0091. By the Factory Builder's numbering it queues after #429 (0097); until 0094 to 0097 land, the records' gap check fails here, as on the others.
Why. P-42 found that GitHub concludes a job it stops at its own
timeout-minutescancelled, nottimed_out, its check run and run with it. A required checkcancelledgives no verdict, so a Lens that runs too long landed on the Maintainer ascheck_unreadable. The trial on a step's own limit found it concludesfailure, its job and check run with it, and a laterif: always()step still runs: rule (a) of the ruling.What changes
tools/check_workflows.py'stimeoutrule holds every workflow here. Eachrun:step sets its owntimeout-minutes, a whole number above none, and a job'srun:steps together leave the jobMARGIN, two minutes, for its other steps. Auses:step needs no limit of its own.continue-on-error, which turns a step's timeout intosuccess, was refused already.ci.yml's hash is recorded again.uses:and post steps took at most 8 s together.make verifytook up to 23 minutes against its job's 25, so that job goes to 28 and its step has 26. A first limit of 22 would have failed passing runs.eval.ymlandrelease.ymlchange only in their limits. The eval job keeps its 120 minutes andBUDGET; its steps have 1, 3, 3, 110 and 1. Its run step's 110 cannot cut a case, since its cases end within 110 minutes of the plan and the plan, fetch and install go first.release.movehas 10 of 15.BUDGETand the Engine step to its longest tier.failure, its outcome left or not, orcancelledwith no outcome, nevertimed_out. Its rule is renameda_run_past_its_limit_fails, asked by P-18 and unverified until P-18 has a fixture.What this does not change: a Run past its limit is no attempt.
applystill runs, and leavesenvironment,run_failed, for any run job that did not succeed, as it did before this. So the automatic pause and the Run ceiling bound it, not the attempts. By the Factory Builder's ruling (option A) the code stays, since classing a failed run job asitemwould count outages as attempts. #433 asks whether it should count, and what that needs from the run job's outputs.Checks
make verify: CI'schecksjob passed at927bd56, synced with main through Workflow check: a list under on: is one only where its events begin with an item (#426) #428 (Workflow check: a list under on: is one only where its events begin with an item). A run on an export ofd0dd123was stopped unfinished on a loaded machine, and none ran at this head, so CI is the evidence for it.d0dd123: four counter-examples Workflow check: a list under on: is one only where its events begin with an item (#426) #428 landed have run: steps with no limit.927bd56gives each its limit.python3 -m tools.mutants: all eight CI shards passed at927bd56. It was not run whole at a desk.Reviews
Structured (
review-findings/1, parsed byreview_parse.py), on 4793d94, before the Factory Builder's conditions and the fix round. AGY (Argon) read again on 9315ab2, since the rule's logic changed: a clean read of all 12 parts.4793d944793d944793d944793d94tools/check_workflows.py:774tools/check_workflows.py:779.github/workflows/eval.yml:50docs/architecture/software-factory-design.md:923tools/check_workflows.py:776tools/check_workflows.py:779tools/check_workflows.py:776tools/check_workflows.py:779tools/check_workflows.py:779🤖 Generated with Claude Code