Skip to content

#364's Muse minors: P-52 leaves a refused mint's token to its trap, create_check_run is held, and the App script says the head its push made - #385

Merged
don-petry merged 5 commits into
mainfrom
fix/364-muse-minors
Oct 29, 2026
Merged

don-petry merged 5 commits into
mainfrom
fix/364-muse-minors

Conversation

@don-petry

@don-petry don-petry commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The follow-on #364 owes: Muse's three minors, and the push-head bug window 2 found in the App script. No record: it adds no rule.

  • tools/trial_p52_pause.sh: a token a refused mint carried is left to the trap, which revokes it and says so; the refusal says "the mint was refused". Tests: the revocation is read and no token is said anywhere; a refusal that carries none revokes nothing.
  • roles/pr-review.json: the review Role's create_check_run is held by a test and a mutant (decision 0059).
  • tools/trial_as_app.sh:
    • It says the head its push made, reading the pull request until GitHub moves it there, at most five times, and warns when it never does. The second machine-user window printed the head before the push.
    • It reads the mint's token after the last status line's headers, its capture starting there. GitHub pretty-prints an empty list across a blank line, which hid the window's token; the fix was on the window's branch, now on main.
    • Tests for each; mutants for each.

Not here: Muse's third minor, P-39's reach read held against the installations' last change. An installation's repos cannot be read through a gh login (403), so the check needs the Maintainer's run of tools/trial_p39_reach.sh first, since the installations changed on 2026-10-27. It goes with P-39's re-read and the controller's pull_requests: write.

Verify: PATH=/usr/bin:/bin SIM_SEEDS=40 make verify, run alone, passed (1303 tests). Mutants: each new one checked killed in place; CI's shards are the gate. gitleaks: no leaks.

Reviews: Claude review with a security pass (approve; four minors, fixed). Muse: not run (Maintainer, 2026-10-20: Kernel/hook only). AGY: not run (quota); owed.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 4 commits October 28, 2026 18:18
… and its token as window 2 found GitHub sends them

- tools/trial_p52_pause.sh leaves a token a refused mint carried to its
  trap, which revokes it and says so; the test reads the revocation.
- roles/pr-review.json's create_check_run is held by a test and a mutant.
- tools/trial_as_app.sh says the head its push made, reading the pull
  request until GitHub moves it there, and reads the mint's token after
  the last status line's headers, as GitHub pretty-prints an empty list
  across a blank line; a test and a mutant each.

The third minor, P-39's reach read against the grants read, waits on the
Maintainer's run of tools/trial_p39_reach.sh and goes with P-39's re-read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… line, a head that never moves is said, and a refused mint says so

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing the tree

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 28, 2026 23:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T00:11:32.143252Z — PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 221a5a2 and 15db036.

Files selected for processing: 4
  • tests/test_tools.py
  • tools/mutants.py
  • tools/trial_as_app.sh
  • tools/trial_p52_pause.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@don-petry
don-petry added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@don-petry

Copy link
Copy Markdown
Contributor Author

This pull request left the merge queue at 01:06Z on failed checks: five mutant shards of its merge group failed on their baseline alone ("the run took longer than 600 s"), with no mutant run and no test failed. It was enqueued again once, as the orchestrator ruled on 2026-10-29 until per-shard baselines land.

🤖 Addressed by Claude Code

@don-petry
don-petry added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit ff96324 Oct 29, 2026
19 checks passed
@don-petry
don-petry deleted the fix/364-muse-minors branch October 29, 2026 06:30
don-petry added a commit that referenced this pull request Oct 29, 2026
#385 landed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Oct 29, 2026
P-23's record title, 0084, and main's #385.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
YasirBinMudassir pushed a commit to YasirBinMudassir/software-factory that referenced this pull request Nov 7, 2026
… the step, and five rules are held (combsmith#397)

* Argon's owed reads of the Release PRs: a home that is no object stops the step, and five rules are held

Argon (gemini-4-argon-high) read the merged combsmith#340, combsmith#354, combsmith#358 and combsmith#364 against their parents. Each finding
was checked by hand on main 455e988. Most were false, held already by tests combsmith#379 added; combsmith#340 had none;
combsmith#364's one real minor is with the trials lane in combsmith#385.

- release/move.py: a Controller home that is no object raised AttributeError. It is now read as no home,
  so the step stops as step_unreadable for every command, and no default branch is read for it.
- adapters/candidate.py on_main: the negative cases for main's ref, its type and its sha now carry the
  comparison each would lead to, so the guard itself refuses them.
- adapters/deployments.py and the eval dispatch: an id of 0 is held, each with the answer that would
  follow it.
- tools/check_workflows.py _release_kind: a checkout at another pin, and a release step that runs another
  command, are counter-examples.

No record: Boundaries rows on 0073 and 0076. Eight mutants, each killed by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Release: a home that names no branch stops the step, and an id of True is no id (combsmith#397)

The review round of combsmith#397. The Claude review and security pass, and Muse, each approved, with minors:
- The home's repo and branch were read as text by no test, and a branch that was not text read as main.
  schemas/controller.schema.json requires the branch, so branch() now gives None for one that is missing,
  empty or not text, and the step stops as step_unreadable for every command, reading no default.
- An id of True passed `type(...) is int` in no test: a Deployment and an eval dispatch of id True are held,
  each with the answer its run 1 would give.

The body's combsmith#358 row is corrected too: the release step's command was already held on main, by "a step more",
so only its checkout pin was owed; the new counter-example is kept as a direct case.

Six mutants, each killed by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant