Repository navigation
Kernel: an active_runs that is no count defers, on a pull request and on an issue (#218) - #230
Conversation
… on an issue (#218) A count of active Runs that is no whole number, a bool among them, or is below zero cannot be read: the Run defers as capacity unread, on both sides, and nothing raises. A whole number is read at the limit and below it, as before. One boundary test each side, written first; the two mutants that put the old line back re-pointed and three more each side, each killed by hand; two rows on decision 0034 and a counter-example of a pass below zero. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…now does, and the record row says what the example holds The code standard's "Yes" example showed the guard #218 found short, which the next author would copy; and the row on 0034 cited the counter-example as holding the whole rule, where it holds only that the pass record's schema refuses a count below zero. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…he cases are one table SonarCloud failed the quality gate on 6.3% duplication in new code: the guard's text stood eight times in the mutant table, and the issue's test repeated the pull request's line by line. No Kernel code changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
SonarCloud failed the quality gate on 428445b: 6.3% duplication on new code, against a limit of 3%. The duplicates were the guard's text written eight times in the mutant table and the issue's test repeating the pull request's line by line. 0efdf22 writes the guard once, as |
… Work item SonarCloud still failed the gate on 0efdf22: the fourteen lines from the model provider's deadline to the Run listed unnamed stood word for word on both sides, and the two new lines made them new duplicated code. As derive.overdue does for the limit (#216), derive.run_deferral now reads the deadline, the count of active Runs and the unidentified list once, and decide.py and issue.py call it after the brakes. No Decision changes. The mutants on those lines collapse to one per rule, on derive.py, each naming both sides' tests, and the two that move the brakes below the deferral anchor on the call; all fifteen killed by hand on a scratch copy. One row on 0034. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…rough one helper in derive.py The Claude review's one note on 977cdd8: the directory's own description had derive.py answering only "where does this item stand", while it now holds the deferral of a Run for both sides, as it holds the limit on a wait. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…age's width `make verify` in the worktree caught the line at over 260 characters. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
SonarCloud still failed on 0efdf22 (6.2%): the duplicated block was the fourteen Kernel lines from the model provider's deadline to the Run listed unnamed, identical in |
The page has a budget of forty lines, and the sentence on derive.py's helpers for both kinds of Work item made forty-one: every mutant shard and the verify export failed on the context check. The row on decision 0034 says where the helper lives; the map stays as main has it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
a5aa574's one sentence on |
|
|
|



Why
The Claude review on #216 found that the concurrency check, on both sides, deferred only on an
active_runsof None and compared anything else with>=: a string raised aTypeErrorout ofdecide, and a bool was read as a number. The Controller writes the context, so the fault is the Factory's own, but the rule holds for every fact read from outside: an unreadable fact yields a deferral or a Hold, never an action, and the Kernel never raises. #218 states the rule and names the pattern of #173 (PR #216) and #165 (PR #176).The rule
In
kernel/decide.pyandkernel/issue.py, at the concurrency check,if active is None:becomesif type(active) is not int or active < 0:. Anactive_runsthat is no whole number, a bool among them, or is below zero, or is not there, cannot be read: the Run defers withcapacity_unreadable, as a deadline that cannot be compared withnowdoes since #216. A whole number is read as before, at the limit (concurrency) and below it (admit). Nothing else changes; no reason is new.kernel/issue.pyis lane b's file, and only its concurrency check is touched.tests/test_decide.py::test_an_active_runs_that_is_no_count_defers_and_raises_nothing(Ceilings) andtests/test_issue.py::test_an_active_runs_that_is_no_count_defers_and_raises_nothing(Investigation); ten unreadable values each, then the limit, one below it, and zero.is None,type(...) is not intloosened toisinstance, which reads a bool, and the negative check dropped. All eight were applied by hand to a scratch copy and killed by their named test. The capped filtered run of Mutation run: every mutant names its tests, the slow suites run last, and a builder may break a few #219 cannot take either file (57 and 274 mutants against a cap of 40), so CI's shards are the word on them.examples/invalid/pass.a-count-of-active-runs-below-zero.json: the pass record's schema already refuses a count below zero; the counter-example now says so.The second round: one helper for either kind of Work item
SonarCloud failed the quality gate on new-code duplication: the fourteen lines from the model provider's deadline to the Run listed unnamed stood word for word in
kernel/decide.pyandkernel/issue.py, and the two new lines made them new duplicated code. Asderive.overduedoes for the limit on a wait (#216),derive.run_deferralnow reads the deadline, the count of active Runs and the unidentified list once, and both sides call it right after the brakes (977cdd8). No Decision changes: the two review agents diffed every Decision on both sides between ac876db and the helper head over every shape of every context field and found them identical,decide.py's explicit check of the"unreadable"sentinel included, whichis_timerefuses anyway. The mutants on those lines collapse to one per rule, onderive.py, each naming both sides' tests, and the two that move the brakes below the deferral anchor on the call; all fifteen killed by hand on a scratch copy. One more row on 0034 says where the helper lives;kernel/AGENTS.mdstays as main has it, since its forty-line budget had no room for a sentence on it. This touches more ofkernel/issue.pythan the concurrency check; the constraint was #43's, which editssim/issues.pyand notkernel/issue.py, so nothing conflicts.Reviewers
On the first head, ac876db, and again on the helper head, 977cdd8 (AGY on the helper head: four runs, the first three produced no output because the fallback model called a tool that headless mode denies; the fourth, with the same prompt wrapped in a stronger no-tool framing, read it).
All four read ac876db, the Kernel head, together; the one fix round, 428445b, touched two documents and no code.
sites()on both heads (same 30 pairs and 9 reasons alone), applied the fifteen collapsed and re-anchored mutants by hand (all killed, each on both sides), and held brakes-first on both sides; one doc-line nit onkernel/AGENTS.md, not taken: the page's forty-line budget had no room (a5aa574 tried, and c59646d put it back). On ac876db: approve. It applied all eight mutants by hand (killed) and probed every other context field on both sides with wrong-shaped values (nothing raised). One minor, fixed: the code standard's own "Yes" snippet showed the guard this issue found short, which the next author would copy; it now reads a count as the Kernel does.active_runsthe change is strictly more closed than main on both sides, and no text from the context reaches a Decision. One low wording note, fixed: the row on 0034 cited the counter-example as holding the whole rule, where it holds only that the pass record's schema refuses a count below zero. Noted, not in scope: a config limit of the wrong type would still raise, but the configuration is the Release's own, validated by its schema andcheck_examples, not a fact read from outside.until > nowboundary. Checked and not so: that test's last block compares a real deadline with a realnowat the boundary (at(6)againstat(6)admits), and the mutant applied by hand to a scratch copy is killed by that one test alone, before the issue side's suite it also names.IntEnum,Decimaland the rest on both sides, applied the eight mutants by hand.Verify
make verifyon a freshgit archiveexport withPATH=/usr/bin:/bin SIM_SEEDS=40: passes on ac876db, on 428445b, on 0efdf22 and on the helper head 977cdd8; the final head's run is in a comment. No fullpython3 -m tools.mutantslocally, by the standing rule.Closes #218
🤖 Generated with Claude Code