Skip to content

write_unmatched clears once the pull request it names leaves the open set, so a machine-user write nobody matched closes its own alarm #787

Closed

Description

@don-petry

Seen in #779's hand merge under a Pause (#198's third box, 2026-11-12):

Pass Poller run Alerts
p_JTGWHDP93NXGJ6491724, 22:54:29Z 43324178715 paused, reconciliation_unreadable, write_unmatched
p_2TB94E7ERTXT8JXEXT4X, 23:07:34Z 43326130229 paused, write_unmatched (#779 merged)
p_MYG4BA801TNYRE46E4H9, 23:08:27Z 43326260959 write_unmatched
p_KKMVV2Q1VSRQY190Z5HT, 23:12:33Z 43326875751 none

The write was review 5883244267, the Maintainer's hand approval as the machine user, which record 0198 expects to alarm. The alarm cleared one pass after the merge, with nobody matching it. The "Factory alerts" issue that carried it (#786) closed itself at 23:15:27Z. Likely cause, not yet read in the code: reconciliation reads the machine user's writes only against open pull requests, so a write on a pull request that has since merged leaves the window.

This time the write was expected. But a write by the machine user's login that nobody made, followed by a merge, would raise the alarm and close it again within minutes, leaving only the opening notification.

The question to rule on: should write_unmatched stand until a person matches the write (or for the reconciliation window of decision 0112), whether or not its pull request is still open? Or is the opening notification enough? Either way, record the answer. If it should stand, it needs a boundary test and a mutant.

Not urgent: today the only use of the login is the Maintainer's own, by hand.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions