Skip to content

A gate set's split needs no case that expects a blocking Finding #691

Closed

Description

@don-petry

Why

split_ok in harness/eval/__init__.py holds every set, a gate set too, to BLOCKING_LEAST = 1 case expecting a blocking Finding. blocking_pass already closes nothing by itself (decision 0150), and a gate set brings its own bars and least of a kind (#613). A gate set built to grade only what no deterministic check holds need not hold a blocking case, since the defects a blocking Finding marks are mostly the ones a check holds (#587–#590). Under today's rule such a set is eval_split_short on every run, so its gate can never pass.

The change

For a gate set (gate_set(found)), split_ok asks only kind_least_of of each kind. blocking_pass is still reported, as a word that closes nothing. A development set is unchanged.

Done when

  • Tests: a gate set with no blocking case and its kinds at their least is split_ok; a development set with none is not, as today; aggregate_verdict and pooled_verdict pass a good report of such a gate set.
  • A mutant that holds a gate set to BLOCKING_LEAST again is killed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions