Skip to content

SonarCloud: miscellaneous findings #52

Closed as not planned
Closed as not planned

Description

@don-petry

SonarCloud: miscellaneous findings

5 open SonarCloud finding(s) in petry-projects/software-factory, worst severity CRITICAL. Generated by the org SonarCloud Audit.

View in SonarCloud →

Findings

Rule Count Representative message
python:S1192 4 Define a constant instead of duplicating this literal "*.json" 3 times.
python:S1871 1 Either merge this branch with the identical one on line "59" or change one of the implemen

Affected files

  • tools/mutants.py (3)
  • kernel/derive.py (1)
  • tools/check_examples.py (1)

Priority

Labeled priority:critical — mapped from this bucket's worst SonarCloud severity (CRITICAL).

Acceptance

  • All findings in this workstream resolved to zero in SonarCloud
  • No behavior change; CI green
  • Real fixes (no blanket NOSONAR unless a confirmed false positive, noted inline)

Idempotent issue — updated automatically each audit run; auto-closed when the finding count reaches zero.

Activity

  1. added
    sonarcloud-auditSonarCloud audit finding (idempotent marker)
    dev-leadFor dev-lead agent pickup
    dev-lead:hands-offExclude from dev-lead agent automation
    and removed
    dev-leadFor dev-lead agent pickup
    on Oct 13, 2026
  2. don-petry commented on Oct 19, 2026

    @don-petry
    ContributorAuthor

    Closed on the Maintainer's decision of 2026-10-19 (plan review, decision 4). This repo departs from the org's workflow and ruleset standards where docs/decisions/0014-where-this-repo-departs-from-the-orgs-standards.md says why: one required check, no proof-of-concept workflows, no bypass actor on main, and rulesets the design (§4.9, #62) sets itself. This report asks for something that decision declines or that the design forbids, so it serves no requirement here. The standards repo is asked to exclude combsmith/software-factory from the audit; if it cannot, the next report is labelled hands-off and left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-lead:hands-offExclude from dev-lead agent automationpriority:criticalSonarCloud CRITICAL severitysonarcloud-auditSonarCloud audit finding (idempotent marker)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions