You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Checks port: a required Lens's check is read only where its details URL is the job's own, as P-35 found #439
Why. Trial P-35 (canary, 2026-10-30) showed that a job with GITHUB_TOKEN and checks: write can create a check run that lands in another workflow's suite. It then reads with the same name, App and path as that workflow's real job, so decision 0026's pin does not prove which job reported. The forge test found a tell:
GitHub kept a forged external_id.
GitHub ignored a forged details_url, leaving /runs/ID.
A real job's reads .../actions/runs/{run id}/job/{check run id}.
This was shown on one forging attempt and is not a promise from GitHub, so a mismatch must fail closed.
Ruling (Factory Builder, 2026-10-30). A required Lens run by GitHub Actions is read only from a check whose detailsUrl has the job's form, with its run id equal to the check's workflowRun.databaseId and its job id equal to the check run's databaseId. Any other check under that name, from that App and file, leaves the Lens unreadable, for the Maintainer, as a check from another path does. This adds to the rule that every check under the name must pass; it does not replace it.
Done when
adapters/checks.py reads detailsUrl and the two ids, and holds the rule. A fixture from P-35 shows a real job read as the Lens's and a created check left unreadable.
The fake (sim/) models both forms, so the simulator's fake does not differ from what P-35 recorded.
Boundary tests and mutants hold each comparison. A malformed or absent URL is unreadable.
Say what happens to tools/ and release/ reads of verify, which read the same check (not_verified): whether they take the rule too, and why.
Decision 0026 gets a Boundaries row, beside P-35's record.
If GitHub changes the URL's form, every required Lens goes unreadable and every item holds for the Maintainer. That is the accepted failure: loud, and on the safe side.
P-35's fixture for this rule lands in the PR for #186, on branch trials/p35-p38, once records 0098-0102 are on main. It adds a pending test, tests/test_adapters.py::test_a_created_check_under_a_lens_name_does_not_pass, which replays a real created check: take @pending off it when the port requires a real job's details.
Two facts for the rule, from the fixture:
A job with needs has no check run until it starts, so a forged success stands alone and reads as passing until then.
A job's token can change another job's external_id and output title, but not its details_url: GitHub answers 200 and leaves it as it was.
Activity
don-petry commentedon Oct 31, 2026
P-35's fixture for this rule lands in the PR for #186, on branch
trials/p35-p38, once records 0098-0102 are on main. It adds a pending test,tests/test_adapters.py::test_a_created_check_under_a_lens_name_does_not_pass, which replays a real created check: take@pendingoff it when the port requires a real job's details.Two facts for the rule, from the fixture:
needshas no check run until it starts, so a forged success stands alone and reads as passing until then.external_idand output title, but not itsdetails_url: GitHub answers 200 and leaves it as it was.🤖 Addressed by Claude Code
Merge main into #439; the reads on its final head: another App's chec…
Checks port: a required Lens's check is read only where its details a…