Skip to content

Applied port: a later review by the same Lens supersedes its earlier records for a thread that is gone #347

Closed

Description

@don-petry

Part of the epic "Epic: slice 1, first approval. A Release on next reviews a pull request to this repo, and the machine user's approval stands" (#182).

Follows "Threads port: a Lens's recorded Finding comment missing from the threads read leaves it unreadable (#331, part 2)" (#338) and decision 0070, by the Factory Builder's ruling of 2026-10-26, option (b).

Why. Under decision 0070, every thread a Lens's applied/1 records must be in the threads read, opened by that Lens, or the pull request's threads read is unreadable and the Kernel defers. A Lens comment deleted whole takes its thread with it, and no read can tell that the thread was resolved before it went. The pull request is then held until that record passes the artifact retention, 90 days, whatever anyone does.

The rule. A later Run of the same Lens supersedes that Lens's earlier records for the threads-presence rule when:

  • it reviewed the pull request at a head at or after the earlier Run's;
  • its applied/1 was read whole.

A fresh review then releases the pull request. If the problem the deleted Finding named still stands, the new Run raises it again, as a Finding on a thread of its own.

  • The superseding Run must be the same Lens. Another Lens's Run supersedes nothing.
  • A superseded record still counts for any thread the new Run also records.
  • The join, each Lens thread's category and severity from its Lens's one Finding, is not changed by this.

Not taken: a person's label as an override. Who may apply such a label needs its own decision (decisions 0052 and 0061).

Done when

  • Boundary tests in tests/test_adapters.py, each with a mutant:
    • a later Run of the same Lens on the current head releases a gone thread;
    • a Run of another Lens does not;
    • a Run on an earlier head does not;
    • a record read short does not;
    • a thread both Runs record is still held to its opener.
  • Decision 0070's cost row is re-pointed to it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions